Clearing the searched token in the scripts filter should also clear the "find next" history

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Developer Tools: Debugger
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ioana (away), Assigned: vporof)

Tracking

15 Branch
Firefox 16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120621 Firefox/15.0a2 (20120621042006)

STR:
1. Load http://addyosmani.github.com/todomvc/architecture-examples/backbone/index.html in the browser.
2. Type "todos#toggleDo" in the filtering textbox.
3. Clear the filtering textbox.
4. Type "todos@toggleDo" in the filtering textbox.

When using "#", the first result of the search is displayed automatically. When using "@", the first result of the search is only displayed after the user presses Enter once. 

It should work the same way for "@" as for "#": displayed the first result automatically, then show the second result when pressing Enter.
(Assignee)

Comment 1

5 years ago
@ shouldn't work at all for now (and it should have a different meaning). The reason why it works now is more of an artifact (pressing Enter jumps to the next found token, regardless of what's written in the filtering textbox; even if you have an empty textbox, it will still jump).

Thanks for noticing this. Renaming the bug.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Summary: Filtering with "@" should be consistent with the "#" filtering → Clearing the searched token in the scripts filter should also clear the "find next" history
(Assignee)

Updated

5 years ago
Priority: -- → P3
(Assignee)

Comment 2

5 years ago
Created attachment 638772 [details] [diff] [review]
v1
Attachment #638772 - Flags: review?(past)
Comment on attachment 638772 [details] [diff] [review]
v1

Review of attachment 638772 [details] [diff] [review]:
-----------------------------------------------------------------

Right on!
A small test for this inside browser_dbg_scripts-searching-01.js would be appropriate.
Attachment #638772 - Flags: review?(past) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 642343 [details] [diff] [review]
v1

Added test.
Whiteboard: [land-in-fx-team]
Attachment #638772 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/6a0dfbde4089
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/6a0dfbde4089
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
You need to log in before you can comment on or make changes to this bug.