767401 - Clearing the searched token in the scripts filter should also clear the "find next" history

Status: RESOLVED FIXED

Description

[Ioana (away)]

Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120621 Firefox/15.0a2 (20120621042006)

STR:
1. Load http://addyosmani.github.com/todomvc/architecture-examples/backbone/index.html in the browser.
2. Type "todos#toggleDo" in the filtering textbox.
3. Clear the filtering textbox.
4. Type "todos@toggleDo" in the filtering textbox.

When using "#", the first result of the search is displayed automatically. When using "@", the first result of the search is only displayed after the user presses Enter once. 

It should work the same way for "@" as for "#": displayed the first result automatically, then show the second result when pressing Enter.

Comment 1

[Victor Porof [:vporof][:vp]]

@ shouldn't work at all for now (and it should have a different meaning). The reason why it works now is more of an artifact (pressing Enter jumps to the next found token, regardless of what's written in the filtering textbox; even if you have an empty textbox, it will still jump).

Thanks for noticing this. Renaming the bug.

Comment 2

[Victor Porof [:vporof][:vp]]

Created attachment 638772 [details] [diff] [review]
v1

Comment 3

[Panos Astithas [:past] (please needinfo?)]

Comment on attachment 638772 [details] [diff] [review]
v1

Review of attachment 638772 [details] [diff] [review]:
-----------------------------------------------------------------

Right on!
A small test for this inside browser_dbg_scripts-searching-01.js would be appropriate.

Comment 4

[Victor Porof [:vporof][:vp]]

Created attachment 642343 [details] [diff] [review]
v1

Added test.

Comment 5

[Panos Astithas [:past] (please needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/6a0dfbde4089

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6a0dfbde4089