dependentlibs.py has the following snippet : if ext == '.dll': func = dependentlibs_dumpbin elif ext == '.so': func = dependentlibs_readelf elif ext == '.dylib': func = dependentlibs_otool This doesnt take into account all bsd platforms where configure.in sets DLL_SUFFIX to .so.1.0 (or to our controlled-versionning lib variable .so.${SO_VERSION} on OpenBSD), so this breaks with cryptic messages : Traceback (most recent call last): File "/home/buildslave/mozilla-central-i386/build/xpcom/stub/dependentlibs.py", line 102, in <module> main() File "/home/buildslave/mozilla-central-i386/build/xpcom/stub/dependentlibs.py", line 99, in main print '\n'.join(dependentlibs(lib, options.libpaths, func)) UnboundLocalError: local variable 'func' referenced before assignment I'd suggest matching elf platforms with elif ext[0:3] == '.so':, which i'm testing right now and will post a patch for if it works.
Actually it's a bit more complicated since splitext returns .0 as ext...
Created attachment 635884 [details] [diff] [review] also match libname on lib.*.so.* re.match on lib.*\.so\..* fixes the issue for me and probably netbsd/freebsd
Created attachment 636154 [details] [diff] [review] also match libname on lib.*.so.* New patch rebased after #767024
Comment on attachment 636154 [details] [diff] [review] also match libname on lib.*.so.* Review of attachment 636154 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/stub/dependentlibs.py @@ +94,5 @@ > lib = args[0] > ext = os.path.splitext(lib)[1] > if ext == '.dll': > func = dependentlibs_dumpbin > + elif ext == '.so' or re.match('lib.*\.so\..*',lib): Please use fnmatch.fnmatch instead.
Created attachment 636817 [details] [diff] [review] use fnmatch to match lib*.so.* Sure, that also works and is nicer (my python fu is weak)
Comment on attachment 636817 [details] [diff] [review] use fnmatch to match lib*.so.* Review of attachment 636817 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/stub/dependentlibs.py @@ +95,5 @@ > lib = args[0] > ext = os.path.splitext(lib)[1] > if ext == '.dll': > func = dependentlibs_dumpbin > + elif ext == '.so' or fnmatch.fnmatch(lib,'lib*.so.*'): Please add a whitespace after the comma. I think you can lift the lib prefix and just use *.so.*
Right, pushed it that way. https://hg.mozilla.org/integration/mozilla-inbound/rev/c7b0713958d6
https://hg.mozilla.org/mozilla-central/rev/c7b0713958d6
or
