76746 - Setting focus to textbox (edit field) doesn't work in dialogs

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Charles Manske]

Opening any property dialog such as Image or Link, where the initial value
of the textbox is empty, we set initial focus by calling SetTextboxFocus().
Today, the caret doesn't appear and focus isn't in the appropriate textbox.
If I change the JS for "SetTextboxFocus()" to simply call:
textbox.select();
The current code for "SetTextboxFocus()" does this:
  if (textbox.value.length > 0)
     textbox.select();
  textbox.focus();

so the '.focus()' is the problem.

Comment 1

[Charles Manske]

probably not an editor bug, but I'll investigate.

Comment 2

[sujay]

Charley you beat me to it...I was gonna file this one... :-)

Simon suggested filing this to Saari as an event handling bug..

Comment 3

[sujay]

Cc: saari and shir.

Comment 4

[Simon Fraser [no longer active]]

This isn't jsut composer dialogs. It happens in the Find dialog too, so that 
would make it a toolkit problem.

Comment 5

[Charles Manske]

Saari: What new stuff went in? This is a regression from yesterday.

Comment 6

[Blake Ross]

bryner had some related stuff.

Comment 7

[Charles Manske]

god damn midair collisions! I'm really tired of it failing to either keep my
previous form entries or at least allow me to "submit anyway" both are busted
in 6.01.
This should be fixed for 0.9

Comment 8

[Charles Manske]

While certainly suspicious, removing Bryner's changes didn't seem to fix this.
If we call ".select()" on the textbox, it is fine, ".focus()" is the problem.

Comment 9

[Charles Manske]

I see lots of other focus-related checkins: DR? HYATT?
Handing this over to XPFE.

Comment 10

[Dan Rosen]

this is probably a focus regression care of hyatt. i'd have guessed bryner
first, but see cmanske's comments.

Comment 11

[David Hyatt]

Mine.

Comment 12

[David Hyatt]

Attachment: Fix for regression

Comment 13

[David Hyatt]

ssari has done an r.

Comment 14

[Chris Waterson]

sr=waterson

Comment 15

[Asa Dotzler [:asa]]

a=[e-mail] for checkin to 0.9

Comment 16

[David Hyatt]

Fixed.

Comment 17

[Peter Trudelle]

*** Bug 76576 has been marked as a duplicate of this bug. ***

Comment 18

[/\/\arcio Galli]

spam for you guys:

bug 76576
and
bug 76746

and new incidents related with focus in textfields. I have not reopenned this
one because I don't know exaclty if those two are related with this bug.

Comment 19

[/\/\arcio Galli]

sorry... please ignore my last two references to bugs..

this bug actually.. is the one in question.
bug 76974

Comment 20

[Vadim Berezniker]

This problem is still evident under linux. (build 2001122721)
I'm assuming that this problem would now be caused by a different bug or maybe a
regression?

Should I file a new bug? All the existing bugs tend to end up at this bug.

Comment 21

[sujay]

Vadim, is this still a problem for you? if so please REOPEN or file a new bug.

Comment 22

[Vadim Berezniker]

No. I haven't experienced this problem for a very long time.

Comment 23

[sujay]

verified. REOPEN if anyone still sees a problem.