767462 - Allow controlling outside-click event consumption with an attribute

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

On Windows (I don't know about other platforms) panels have a bug or misfeature that intermittently renders the previous contents when opening a panel a second time. This currently affects the identity popup (there's a bug filed, but I couldn't find it). A workaround for this is to set hidden=true when the panel hides. However, this throws the popup box object away, making previous popupBoxObject.setConsumeRollupEvent calls ineffective.

Comment 1

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #0)
> This currently affects the identity popup (there's a bug filed, but I couldn't find it).

bug 684534

Comment 2

[Neil Deakin]

Comment on attachment 635805 [details] [diff] [review]
patch

I'd call the attribute 'consumeclicks' (or 'consumeoutsideclicks') since there isn't really a 'rollup' event fired in either case.

Comment 3

[Dão Gottwald [:dao]]

consumeoutsideclicks sounds good to me, I can use that.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch v2

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/16477f23e113

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/16477f23e113

Comment 7

[Mike Kaply [:mkaply]]

I've added documentation for this. Can someone please verify?

https://developer.mozilla.org/en-US/docs/XUL/panel#a-consumeoutsideclicks

https://developer.mozilla.org/en-US/docs/XUL/Attribute/consumeoutsideclicks

Should I add to menupopup as well? Or is it really only relevant for panels?

Comment 8

[Dão Gottwald [:dao]]

You probably wouldn't want to set this on a menupopup. At least I can't think of a case where it would make sense.

Comment 9

[Mike Kaply [:mkaply]]

I've made it panel only.