Allow controlling outside-click event consumption with an attribute

RESOLVED FIXED in mozilla16

Status

()

Core
XUL
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({dev-doc-complete})

Trunk
mozilla16
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.41 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 635805 [details] [diff] [review]
patch

On Windows (I don't know about other platforms) panels have a bug or misfeature that intermittently renders the previous contents when opening a panel a second time. This currently affects the identity popup (there's a bug filed, but I couldn't find it). A workaround for this is to set hidden=true when the panel hides. However, this throws the popup box object away, making previous popupBoxObject.setConsumeRollupEvent calls ineffective.
Attachment #635805 - Flags: review?(enndeakin)
(Assignee)

Comment 1

5 years ago
(In reply to Dão Gottwald [:dao] from comment #0)
> This currently affects the identity popup (there's a bug filed, but I couldn't find it).

bug 684534
Comment on attachment 635805 [details] [diff] [review]
patch

I'd call the attribute 'consumeclicks' (or 'consumeoutsideclicks') since there isn't really a 'rollup' event fired in either case.
Attachment #635805 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 3

5 years ago
consumeoutsideclicks sounds good to me, I can use that.
Keywords: dev-doc-needed
Summary: Allow controlling rollup event consumption with an attribute → Allow controlling outside-click event consumption with an attribute
(Assignee)

Comment 4

5 years ago
Created attachment 635877 [details] [diff] [review]
patch v2
Attachment #635805 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/16477f23e113
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/16477f23e113
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 767813
(Assignee)

Updated

5 years ago
No longer blocks: 767133
(Assignee)

Updated

5 years ago
Blocks: 767975

Comment 7

4 years ago
I've added documentation for this. Can someone please verify?

https://developer.mozilla.org/en-US/docs/XUL/panel#a-consumeoutsideclicks

https://developer.mozilla.org/en-US/docs/XUL/Attribute/consumeoutsideclicks

Should I add to menupopup as well? Or is it really only relevant for panels?
(Assignee)

Comment 8

4 years ago
You probably wouldn't want to set this on a menupopup. At least I can't think of a case where it would make sense.

Comment 9

4 years ago
I've made it panel only.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.