[shipping] sign-off view should show warning count

RESOLVED FIXED in 2.3

Status

Webtools
Elmo
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The sign-off view should show the warning count in builds, as they can be fatal.
(Assignee)

Updated

6 years ago
Assignee: nobody → l10n
(Assignee)

Comment 1

6 years ago
Created attachment 641001 [details] [diff] [review]
show the warning, and add tests for showrun to begin with

run tests, too. html5lib is part of vendor/lib, so I used that to write meaningful tests, in particular that's nice for the data- stuff.
Attachment #641001 - Flags: review?(peterbe)
Comment on attachment 641001 [details] [diff] [review]
show the warning, and add tests for showrun to begin with

Review of attachment 641001 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/l10nstats/templatetags/run_filters.py
@@ +36,4 @@
>          cmp_segs.append('%d error(s)' % run.errors)
>      if missing:
>          cmp_segs.append('%d missing' % missing)
> +    if run.warnings:

Couldn't all of these be:

if run.warnings == 1:
    cmp_segs.append('1 warning')
elif run.warnings:
    cmp_segs.append('%d warnings' % run.warnings)
Attachment #641001 - Flags: review?(peterbe) → review+
(Assignee)

Comment 4

6 years ago
Landed with a hacked-in plurals form, and deployed on -dev-.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.3
Version: Trunk → 2.3
You need to log in before you can comment on or make changes to this bug.