767491 - [shipping] sign-off view should show warning count

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect, P1)

Description

[Axel Hecht [:Pike]]

The sign-off view should show the warning count in builds, as they can be fatal.

Comment 1

[Axel Hecht [:Pike]]

Attachment: show the warning, and add tests for showrun to begin with

run tests, too. html5lib is part of vendor/lib, so I used that to write meaningful tests, in particular that's nice for the data- stuff.

Comment 2

[Peter Bengtsson [:peterbe]]

Comment on attachment 641001 [details] [diff] [review]
show the warning, and add tests for showrun to begin with

Review of attachment 641001 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/l10nstats/templatetags/run_filters.py
@@ +36,4 @@
>          cmp_segs.append('%d error(s)' % run.errors)
>      if missing:
>          cmp_segs.append('%d missing' % missing)
> +    if run.warnings:

Couldn't all of these be:

if run.warnings == 1:
    cmp_segs.append('1 warning')
elif run.warnings:
    cmp_segs.append('%d warnings' % run.warnings)

Comment 3

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/34cd1436bf48681c9c20a852f39aa0c28f5a727c
bug 767491, show warnings in signoff view, r=peterbe

Comment 4

[Axel Hecht [:Pike]]

Landed with a hacked-in plurals form, and deployed on -dev-.