767541 - AwesomeScreen Search suggestions not appearing with Swype Beta until space is entered

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Using the latest Swype Beta, go to AwesomeScreen, type "foo". No suggestions appear.
2) Hit space. Suggestions appear.

Expected results: suggestions appear in step 1.

This isn't a problem on the stock browser.

Comment 1

[Chris Peterson [:cpeterson]]

Brian, what is the version number of "the latest Swype Beta"? I am using Swype 3.26.92.34839.34842.4823.N7000_EUR. (phew!)

Which version of Fennec are you testing?

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: patch

Looks like we return early if we have a composition string, which must be happening in this case. I didn't see this when I added the suggestion code below.

Comment 3

[Brian Nicholson (:bnicholson)]

(In reply to Chris Peterson (:cpeterson) from comment #1)
> Brian, what is the version number of "the latest Swype Beta"? I am using
> Swype 3.26.92.34839.34842.4823.N7000_EUR. (phew!)
> 
> Which version of Fennec are you testing?

To get the Swype Beta, I had to register and download it from Swype's website (http://beta.swype.com/). I just received this update last night (6/21).

The version is 1.0.3.5809.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 635920 [details] [diff] [review]
patch

Review of attachment 635920 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/0de46ea58d83

Comment 6

[Chris Peterson [:cpeterson]]

Brian, I think you should uplift your fix to Aurora 15, but it might be too risky for a not-so-serious bug to be uplifted to Fennec 14 or .N+. What do you think?

Comment 7

[Brian Nicholson (:bnicholson)]

(In reply to Chris Peterson (:cpeterson) from comment #6)
> Brian, I think you should uplift your fix to Aurora 15, but it might be too
> risky for a not-so-serious bug to be uplifted to Fennec 14 or .N+. What do
> you think?

Search suggestions aren't in Aurora (yet), so this won't be a problem there...but I agree that this should be uplifted at the same time bug 586885 lands.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0de46ea58d83