767600 - Long tap stops working after trying to long tap in an iframe

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[:Margaret Leibovic]

Attachment: logcat

I came across this while trying to test text selection, but it doesn't seem to be (at least directly) related to my code. This happens after long tapping in one of the iframes here:
http://people.mozilla.com/~mleibovic/test/text_select_iframe.html

If I try going to the awesomescreen to navigate to another page, I eventually end up with an ANR dialog.

I attached the relevant logcat. When I tried to long tap in the iframe, this is the line that appeared:
I/GeckoSubdocumentScrollHelper( 2503): Got message: Panning:Override

Comment 1

[:Margaret Leibovic]

Wes, cc'ing you in case you have time to lend any advice here.

Comment 2

[:Margaret Leibovic]

Attachment: patch

The immediate problem was caused by an infinite loop in updateCacheOffset, but after fixing that, I realized that my iframe calculations had a bunch of problems. After much thinking things through, I realized that we don't need to be computing that total scroll offset like we were, since almost all the time we just need coordinates relative to _view. The only time we really need any offset is when we're trying to compute pointInSelection in endSelection, and that isn't a scroll offset, but rather the offset of the positioning of the iframe. I made a some test pages to test this out, and it looks to be working well now:
http://people.mozilla.com/~mleibovic/test/text_select_iframe.html
http://people.mozilla.com/~mleibovic/test/two_level_iframes.html

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2efe5f77b952

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2efe5f77b952

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

This has been resolved and doesn't seem to be a regression so we won't track this.

Comment 6

[Martijn Wargers (dead)]

Thus was almost certainly a regression.

Comment 7

[:Margaret Leibovic]

Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6

Comment 8

[Xiao Meng Wei :xwei]

Verified on SE Xperia mini pro with fennec 15 beta 2.

Comment 9

[Adrian Tamas (:AdrianT)]

Unable to reproduce the issue on:

Firefox Mobile 16.0b5 / Aurora 16.0a2 2012-09-26/ Nightly 17.0a1 2012-09-27
Samsung Galaxy R (Android 2.3.4)

Marking as verified on Firefox Mobile 16