The default bug view has changed. See this FAQ.

Update nsIObjectLoadingContent interface for click-to-play

RESOLVED FIXED in mozilla17

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: johns, Assigned: keeler)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

5 years ago
With the addition of click-to-play, adding functions to nsIObjectLoadingContent to let extensions more completely control and inspect c2p behavior is desirable
Just watch out: web code can generally call into the methods on this interface.
Created attachment 648420 [details] [diff] [review]
pluginSupportState

One thing that would be extremely useful for the in-browser ui would be to expose a readonly attribute that says what plugin support state nsObjectLoadingContent came up with (essentially make mFallbackReason readable).
Attachment #648420 - Flags: feedback?(joshmoz)
(Assignee)

Updated

5 years ago
Blocks: 738698
Created attachment 650372 [details] [diff] [review]
patch
Attachment #648420 - Attachment is obsolete: true
Attachment #648420 - Flags: feedback?(joshmoz)
Attachment #650372 - Flags: feedback?(joshmoz)

Comment 4

5 years ago
Comment on attachment 650372 [details] [diff] [review]
patch

Review of attachment 650372 [details] [diff] [review]:
-----------------------------------------------------------------

Seems like a reasonable approach for extensions.

::: content/base/src/nsObjectLoadingContent.cpp
@@ +2441,5 @@
>    return NS_OK;
>  }
>  
> +NS_IMETHODIMP
> +nsObjectLoadingContent::GetPluginFallbackType(PRUint32* aPluginFallbackType)

You might want to add a chrome/content check here, and limit this to chrome callers.
Attachment #650372 - Flags: feedback?(joshmoz) → feedback+
Created attachment 652138 [details] [diff] [review]
pluginFallbackType

Added code to limit this to chrome/extensions. I think we're ready to go ahead with this, so asking for review.
Attachment #650372 - Attachment is obsolete: true
Attachment #652138 - Flags: review?(joshmoz)

Updated

5 years ago
Attachment #652138 - Flags: review?(joshmoz) → review+
This ran green: https://tbpl.mozilla.org/?tree=Try&rev=15c4080ea5e1
Marking checkin-needed.
Keywords: checkin-needed
(Reporter)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b5b8baa5816
Status: NEW → ASSIGNED
Keywords: checkin-needed
(Reporter)

Updated

5 years ago
Attachment #652138 - Flags: checkin+
(Reporter)

Updated

5 years ago
Assignee: jschoenick → dkeeler
https://hg.mozilla.org/mozilla-central/rev/2b5b8baa5816
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

Updated

5 years ago
Blocks: 776208
Depends on: 783836
Backed out for bug 783836:
https://hg.mozilla.org/integration/mozilla-inbound/rev/175c0a74f744
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla17 → ---
Created attachment 653135 [details] [diff] [review]
proposed changes to fix bug 783836

Looks like the |plugin.QueryInterface(Ci.nsIObjectLoadingContent);| interface queries are missed in the tests.
Attachment #653135 - Flags: feedback?(dkeeler)
Created attachment 653542 [details] [diff] [review]
pluginFallbackType v2

Thanks to Yury for pointing out the QueryInterface issue.
Also, I forgot to rev the uuid, so that was wrong.
Asking for review from Jared in case there's something else wrong he might catch.
Attachment #652138 - Attachment is obsolete: true
Attachment #653135 - Attachment is obsolete: true
Attachment #653135 - Flags: feedback?(dkeeler)
Attachment #653542 - Flags: review?(jaws)
Comment on attachment 653542 [details] [diff] [review]
pluginFallbackType v2

Review of attachment 653542 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the test changes. ship it! :)
Attachment #653542 - Flags: review?(jaws) → review+
Let's see if this works better: https://tbpl.mozilla.org/?tree=Try&rev=6985b1f34ab2
(Reporter)

Comment 14

5 years ago
(In reply to David Keeler from comment #11)
> Also, I forgot to rev the uuid, so that was wrong.

(I actually rev'd it in the landing, but forgot to mention it):
https://hg.mozilla.org/mozilla-central/rev/2b5b8baa5816#l2.13
Okay - this ran green on try. If it fails on inbound again, something weird is going on.
Marking checkin-needed.
Keywords: checkin-needed
(In reply to David Keeler from comment #15)
> something weird is going on.

Or clobber vs non-clobber bustage :-)
(Reporter)

Comment 17

5 years ago
pushed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/0ca713e1db47

try:
https://tbpl.mozilla.org/?tree=Try&rev=6985b1f34ab2
Keywords: checkin-needed
(Reporter)

Updated

5 years ago
Attachment #653542 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/0ca713e1db47
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
(Reporter)

Updated

5 years ago
No longer depends on: 767635
You need to log in before you can comment on or make changes to this bug.