767638 - Simplify nsPluginDocument and loading full-page plugins

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[John Schoenick [:johns]]

With the changes in bug 745030, the way we handle channels and fullpage plugins is unnecessarily complex. A nsObjectLoadingContent::AdoptChannel() type call would be able to replace a good deal of edge-case hooks for this

Comment 1

[Josh Aas]

What is the plan here John?

Comment 2

[John Schoenick [:johns]]

Attachment: Greatly simplify loading full-page plugins

So my patches in bug 767633 broke this code path and it was too painful to
touch.

So I just deleted most of it.

Comment 3

[John Schoenick [:johns]]

https://tbpl.mozilla.org/?tree=Try&rev=1c691ae2aca7

Comment 4

[Josh Aas]

Comment on attachment 690648 [details] [diff] [review]
Greatly simplify loading full-page plugins

Review of attachment 690648 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsObjectLoadingContent.cpp
@@ +739,5 @@
>    if (appShell) {
>      appShell->SuspendNative();
>    }
>  
> +  rv = pluginHost->InstantiateEmbeddedPluginInstance(mContentType.get(),

If full page plugin loads are using this path now, then the name of the method isn't great any more - it's no longer necessarily an "embedded" plugin.

Comment 5

[John Schoenick [:johns]]

Attachment: Greatly simplify loading full-page plugins. r=josh

Fixed several comments, carrying over r+

Comment 6

[John Schoenick [:johns]]

Attachment: Rename InitializeEmbedded* plugin functions to just Initialize*

Removed embedded from a ton of function names, also merged
nsPluginStreamListenerPeer::Initialize and ::InitializeEmbedded, which differed
only in in whether or not they set mPStreamListener (and also in several
checks/assertions that were only in one and not the other)

Comment 7

[John Schoenick [:johns]]

Comment on attachment 691580 [details] [diff] [review]
Greatly simplify loading full-page plugins. r=josh

https://hg.mozilla.org/integration/mozilla-inbound/rev/9631d28a19c3
https://hg.mozilla.org/integration/mozilla-inbound/rev/35e4ec23293c

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9631d28a19c3
https://hg.mozilla.org/mozilla-central/rev/35e4ec23293c