Closed Bug 767638 Opened 7 years ago Closed 7 years ago

Simplify nsPluginDocument and loading full-page plugins

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: johns, Assigned: johns)

References

Details

Attachments

(2 files, 1 obsolete file)

With the changes in bug 745030, the way we handle channels and fullpage plugins is unnecessarily complex. A nsObjectLoadingContent::AdoptChannel() type call would be able to replace a good deal of edge-case hooks for this
Blocks: 736998
What is the plan here John?
So my patches in bug 767633 broke this code path and it was too painful to
touch.

So I just deleted most of it.
Attachment #690648 - Flags: review?(joshmoz)
Comment on attachment 690648 [details] [diff] [review]
Greatly simplify loading full-page plugins

Review of attachment 690648 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsObjectLoadingContent.cpp
@@ +739,5 @@
>    if (appShell) {
>      appShell->SuspendNative();
>    }
>  
> +  rv = pluginHost->InstantiateEmbeddedPluginInstance(mContentType.get(),

If full page plugin loads are using this path now, then the name of the method isn't great any more - it's no longer necessarily an "embedded" plugin.
Attachment #690648 - Flags: review?(joshmoz) → review+
Depends on: 767633
Fixed several comments, carrying over r+
Attachment #690648 - Attachment is obsolete: true
Removed embedded from a ton of function names, also merged
nsPluginStreamListenerPeer::Initialize and ::InitializeEmbedded, which differed
only in in whether or not they set mPStreamListener (and also in several
checks/assertions that were only in one and not the other)
Attachment #691585 - Flags: review?(joshmoz)
Attachment #691585 - Flags: review?(joshmoz) → review+
Attachment #691585 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/9631d28a19c3
https://hg.mozilla.org/mozilla-central/rev/35e4ec23293c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Depends on: 870216
No longer depends on: 870216
You need to log in before you can comment on or make changes to this bug.