767660 - "Assertion failure: pnu->isUsed(),"

Status: VERIFIED FIXED

Description

[Gary Kwong [:gkw] [:nth10sd]]

Created attachment 636029 [details]
testcase

The attached testcase asserts js debug shell on m-i changeset cb74a377095a without any CLI flag arguments at Assertion failure: pnu->isUsed(), when the testcase passed in as a CLI argument.

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   97130:70acf458a32d
user:        Benjamin Peterson
date:        Sat Jun 02 20:16:24 2012 +0200
summary:     Bug 759498: fix defaults when arguments are bound as functions, r=jorendorff

Comment 1

[:Benjamin Peterson]

Created attachment 636128 [details] [diff] [review]
fix and assurance that it won't happen again

That was quite a subtle bug! I have no idea why the defaults provoked it; it seems to be a very old bug.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 636128 [details] [diff] [review]
fix and assurance that it won't happen again

Agreed. That's really strange.

Comment 3

[:Benjamin Peterson]

Created attachment 636468 [details] [diff] [review]
a few cosmetic changes

Comment 4

[Gary Kwong [:gkw] [:nth10sd]]

Comment on attachment 636468 [details] [diff] [review]
a few cosmetic changes

Bringing over r+ to avoid potential confusion that this may be a lingering patch in the future.

Landing soon.

Comment 5

[Gary Kwong [:gkw] [:nth10sd]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2ae1e57c5851

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2ae1e57c5851

Comment 7

[Gary Kwong [:gkw] [:nth10sd]]

A type of test for this bug has already been landed because it is already marked in-testsuite+ -> VERIFIED.