Last Comment Bug 767726 - Kill nsISVGChildFrame::DO_NOT_NOTIFY_RENDERING_OBSERVERS
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla17
Assigned To: Jonathan Watt [:jwatt]
: Jet Villegas (:jet)
Depends on:
  Show dependency treegraph
Reported: 2012-06-23 10:56 PDT by Jonathan Watt [:jwatt]
Modified: 2012-07-24 03:02 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (14.33 KB, patch)
2012-07-23 08:35 PDT, Jonathan Watt [:jwatt]
longsonr: review+
Details | Diff | Splinter Review

Description User image Jonathan Watt [:jwatt] 2012-06-23 10:56:47 PDT
With the patch for bug 767647 we stopped invalidating rendering observers under NotifySVGChanged() since ancestor changes can't change a descendant from the point of view of the descendant's rendering observers anyway. (Since when rendering, rendering observers have the elements they reference resolve dimensions relative to them, etc., not their ancestor.)

Anyway, that bug forgot to remove DO_NOT_NOTIFY_RENDERING_OBSERVERS. It's no longer needed, so we should do that.
Comment 1 User image Jonathan Watt [:jwatt] 2012-07-23 08:35:24 PDT
Created attachment 644941 [details] [diff] [review]
Comment 3 User image Ed Morley [:emorley] 2012-07-24 03:02:21 PDT

Note You need to log in before you can comment on or make changes to this bug.