Closed Bug 767797 Opened 12 years ago Closed 12 years ago

'Find in page' menu item inconsistently enabled/disabled on about:home

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox15 verified, firefox16 verified, firefox17 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox15 --- verified
firefox16 --- verified
firefox17 --- verified

People

(Reporter: pretzer, Assigned: Margaret)

References

Details

Attachments

(1 file)

patch
1.22 KB, patch
mfinkle
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
The 'Find in page' menu item is disabled on about:home after fennec was started. After visiting another site and returning to about:home via the back button, the menu item is enabled.
It should always be disabled on about:home. Which build did you see this in?
Latest nightly.
It looks like this never worked properly. We explicitly set it to enabled when *not* on about:home, but I don't see how it gets set to be disabled on about:home...
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/BrowserApp.java#624
Assignee: nobody → margaret.leibovic
Attached patch patch — — Splinter Review 
This seems like it was just a dumb mistake.
Attachment #636457 - Flags: review?(mark.finkle)
Attachment #636457 - Flags: review?(mark.finkle) → review+
Comment on attachment 636457 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): problem in initial patch for bug 695172 (find in page)
User impact if declined: the find in page menuitem won't be disabled on about:home when it should be (find in page doesn't work on about:home)
Testing completed (on m-c, etc.): just landed on inbound
Risk to taking this patch (and alternatives if risky): low-risk logic adjustment for enabling/disabling menuitem
String or UUID changes made by this patch: n/a
Attachment #636457 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/7c28ebe35b15
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #636457 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This code lives in GeckoApp on aurora, so I had to move it over there:
https://hg.mozilla.org/releases/mozilla-aurora/rev/8e1bb8e072bc
status-firefox15: affected → fixed
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
status-firefox16: fixed → verified
status-firefox17: --- → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: