767836 - show custom newtab page in private browsing mode if configured

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

When implementing the solution for new tab in private browsing mode in bug 763468 (described in bug 762938 comment #13) we forgot to always show the custom new tab page if the user configured one.

Comment 1

[Madhavan]

Hi, Can i get some help in getting this bug assigned to me?

Comment 2

[Saurabh Anand [:sawrubh]]

Madhavan, Sorry but I had worked on the previous bug (See 763468) and have started working on this one. Can you please find some other bug ?

Thanks.

Comment 3

[Saurabh Anand [:sawrubh]]

Attachment: Patch v1(Includes the test)

Comment 4

[Saurabh Anand [:sawrubh]]

Attachment: Patch v2 - Rebased Patch v1

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 638807 [details] [diff] [review]
Patch v2 - Rebased Patch v1

Review of attachment 638807 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Saurabh! r=me with the nit fixed. Please send it to try before we can land it.

::: browser/base/content/test/browser_bug767836.js
@@ +6,5 @@
> +const pb = Cc["@mozilla.org/privatebrowsing;1"].
> +           getService(Ci.nsIPrivateBrowsingService);
> +const PREF = "browser.newtab.url";
> +const newTabUrl = Services.prefs.getCharPref(PREF) || "about:blank";
> +const testURL = "http://example.com/";

Nit: these two consts should be upper case.

Comment 6

[Saurabh Anand [:sawrubh]]

https://tbpl.mozilla.org/?tree=Try&rev=426994a259f5

Comment 7

[Saurabh Anand [:sawrubh]]

Attachment: Patch v3

Fixed nit.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/09b9de5e8bb9

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/09b9de5e8bb9