The default bug view has changed. See this FAQ.

show custom newtab page in private browsing mode if configured

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: sawrubh)

Tracking

Trunk
Firefox 16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=ttaubert][lang=js])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
When implementing the solution for new tab in private browsing mode in bug 763468 (described in bug 762938 comment #13) we forgot to always show the custom new tab page if the user configured one.

Comment 1

5 years ago
Hi, Can i get some help in getting this bug assigned to me?
(Assignee)

Comment 2

5 years ago
Madhavan, Sorry but I had worked on the previous bug (See 763468) and have started working on this one. Can you please find some other bug ?

Thanks.
(Assignee)

Updated

5 years ago
Assignee: nobody → saurabhanandiit
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Created attachment 638797 [details] [diff] [review]
Patch v1(Includes the test)
Attachment #638797 - Flags: review?(ttaubert)
(Assignee)

Comment 4

5 years ago
Created attachment 638807 [details] [diff] [review]
Patch v2 - Rebased Patch v1
Attachment #638797 - Attachment is obsolete: true
Attachment #638797 - Flags: review?(ttaubert)
Attachment #638807 - Flags: review?(ttaubert)
(Reporter)

Comment 5

5 years ago
Comment on attachment 638807 [details] [diff] [review]
Patch v2 - Rebased Patch v1

Review of attachment 638807 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Saurabh! r=me with the nit fixed. Please send it to try before we can land it.

::: browser/base/content/test/browser_bug767836.js
@@ +6,5 @@
> +const pb = Cc["@mozilla.org/privatebrowsing;1"].
> +           getService(Ci.nsIPrivateBrowsingService);
> +const PREF = "browser.newtab.url";
> +const newTabUrl = Services.prefs.getCharPref(PREF) || "about:blank";
> +const testURL = "http://example.com/";

Nit: these two consts should be upper case.
Attachment #638807 - Flags: review?(ttaubert) → review+
(Assignee)

Comment 6

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=426994a259f5
(Assignee)

Comment 7

5 years ago
Created attachment 638857 [details] [diff] [review]
Patch v3

Fixed nit.
Attachment #638807 - Attachment is obsolete: true
(Reporter)

Comment 8

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/09b9de5e8bb9
Whiteboard: [good first bug][mentor=ttaubert][lang=js] → [good first bug][mentor=ttaubert][lang=js][fixed-in-fx-team]
Target Milestone: --- → Firefox 16
(Reporter)

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/09b9de5e8bb9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=ttaubert][lang=js][fixed-in-fx-team] → [good first bug][mentor=ttaubert][lang=js]
You need to log in before you can comment on or make changes to this bug.