The default bug view has changed. See this FAQ.

Store meta data in profile

RESOLVED FIXED in mozilla16

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

unspecified
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 636202 [details] [diff] [review]
Store meta data in profile

I want to collect more meta data inside the profile. The platform can be obvious from the profile (sometimes) but knowing the profiling features and configuration can be useful. Once this patch lands I can modify Cleopatra to display this information

Actually I also wanted to add product name (Firefox Vs. Thunderbird, Fennec Vs. b2g) and it's not in this patch.
Attachment #636202 - Flags: review?(jmuizelaar)
(Assignee)

Comment 1

5 years ago
Sample profile:
{
    "meta": {
        "version": 2,
        "interval": 1,
        "stackwalk": 0,
        "jank": 0,
        "platform": "Macintosh",
        "oscpu": "Intel Mac OS X 10.7",
        "misc": "rv:16.0",
        "abi": "x86-gcc3",
        "toolkit": "cocoa"
    },
    "threads": [{
        "samples": [{
            "name": "(root)",
            "frames": [{
                "location": "Startup::XRE_Main"
            }, {
                "location": "Events::ProcessGeckoEvents"
            }, {
                "location": "Timer::Fire"
            }, {
                "location": "JS::CallEventHandler"
            }, {
                "location": "0x443c7f9"
            }],
            "responsiveness": 0.07739
        }]
    }]
}
(Assignee)

Comment 2

5 years ago
Created attachment 636211 [details] [diff] [review]
Store meta data in profile

I added the process type (for multi-process support) and the product name.
Assignee: nobody → bgirard
Attachment #636202 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #636202 - Flags: review?(jmuizelaar)
(Assignee)

Updated

5 years ago
Attachment #636211 - Flags: review?(jmuizelaar)
(Assignee)

Comment 3

5 years ago
Cleopatra will now display relevant metadata if present in the profile:
https://github.com/bgirard/cleopatra/commit/48374ebbbaa86e635c700c88954eb1018feeba16
(Assignee)

Comment 4

5 years ago
Created attachment 636226 [details]
screenshot
Comment on attachment 636211 [details] [diff] [review]
Store meta data in profile

Review of attachment 636211 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/TableTicker.cpp
@@ +525,5 @@
> +    res = appInfo->GetName(string);
> +    if (!NS_FAILED(res))
> +      b.DefineProperty(meta, "product", string.Data());
> +  }
> +

This should be a separate function. Have it return a JSObject *
Attachment #636211 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 6

5 years ago
Good idea
(Assignee)

Comment 7

5 years ago
Created attachment 636986 [details] [diff] [review]
Store meta data in profile

Carry foward r+
Attachment #636986 - Flags: review+
(Assignee)

Updated

5 years ago
Attachment #636211 - Attachment is obsolete: true
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd361ba7118e
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/cd361ba7118e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.