76789 - remove redundant globals from MIME and mail back-end

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P3)

Description

[Chris Waterson]

Need some r= love on this.

Comment 1

[Chris Waterson]

Attachment: remove redundant symbols

Comment 2

[Chris Waterson]

taking, since I have patches.

Comment 3

[Jean-Francois Ducarroz]

I am moving some function into msgbaseutils which is the common static lib used by mailnews modules, that will 
avoid any duplication conflicts. I prefer going this way instead of just declaring them static and therefore having 
the same code at several location.

Comment 4

[Chris Waterson]

jfd, sounds good. I'll kick this bug over to you for now; let me know when you 
get some patches...

Comment 5

[Jean-Francois Ducarroz]

Attachment: propose patch that fix conflict

Comment 6

[Jean-Francois Ducarroz]

my patch is working against a current tree and therefore is missing few thing 
from the original patch waterson posted that would not compile. Here what we 
will have to do:

1) need to remove double-quote on any NS_IMPL_NSGETMODULE
2) same with NS_IMPL_NSGETMODULE_WITH_DTOR
3) need to apply the following patch:
Index: db/msgdb/build/nsMsgDBFactory.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/db/msgdb/build/nsMsgDBFactory.cpp,v
retrieving revision 1.26
retrieving revision 1.26.4.2
diff -u -r1.26 -r1.26.4.2
--- nsMsgDBFactory.cpp  2001/04/11 14:22:36     1.26
+++ nsMsgDBFactory.cpp  2001/04/19 20:31:20     1.26.4.2
@@ -258,9 +258,10 @@
 
 static nsMsgDBModule *gModule = NULL;
 
-extern "C" NS_EXPORT nsresult NSGetModule(nsIComponentManager *servMgr,
-                                          nsIFile* aPath,
-                                          nsIModule** return_cobj)
+extern "C" NS_EXPORT nsresult
+NSGETMODULE_ENTRY_POINT(nsMsgDBModule) (nsIComponentManager *servMgr,
+                                        nsIFile* aPath,
+                                        nsIModule** return_cobj)
 {
     nsresult rv = NS_OK;

Comment 7

[Jean-Francois Ducarroz]

R=varada

Comment 8

[Jean-Francois Ducarroz]

I have checked in my patch. Back to Waterson...

Comment 9

[Chris Waterson]

Ok, what's left to do, jfd?

Comment 10

[Jean-Francois Ducarroz]

we still need to do the stuff I wrote earlier on 2001-04-23 15:47 (see above)

Comment 11

[Chris Waterson]

dprice: all the NS_IMPL_GETMODULE stuff has been done on the branch already, and
ideally could be landed ``on its own''. It will require a bit of cuddling in the
commercial tree; I wonder if it's worth its own bug? Anyway, once that is done,
there really isn't anything left to do on this. So, I'm closing the bug.

Comment 12

[esther]

I need a test scenario for this in order to verify it.  Please!

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

Verified, "I used LXR, Luke".