76790 - modal dialogs inaccessable when switching btwn resolutions

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[sairuh (rarely reading bugmail)]

using 2001.04.19.0x opt comm bits on Mac and WinNT [methinks linux/unix n/a due
to wm issues concerning positioning of dialogs]. basically, if a modal dialog
[eg, Find in Page, or Open Web Location] is placed near/just outside the edge of
the monitor's screen area, and then you reduce the resolution, you won't be able
to access that dialog [or its parent browser window]. this might be an edge
case, however simon pointed out that this might be common for people who switch
btwn a docked workstation monitor and a laptop.

to repro:
0. let's say you start out with a nice monitor resolution --eg, i had 1024x768
on my Mac and 1280x1024 on my winNT box.
1. in a browser window, open a modal dialog --eg, i tested with Find in Page and
Open Web Location.
2. move the dialog to the far right side of the screen, so that only about half
of it is showing.
3. hit Esc and bring the dialog back up again to make sure its position persists
[bug 75657].
4. quit the app.
5. change the screen resolution --eg, i bumped it down to 800x600.
6. restart app, bring up modal dialog.

result: the modal dialog is offscreen, and the parent window is inaccessible.
workaround: you need to hit Esc to cancel the dialog to bring access back to the
browser window --you won't be able to use the dialog (at least not effectively
:).

Comment 1

[Peter Trudelle]

Not just modal, document windows and secondary windows like Find dialog can also
come up offscreen due to this, even after a restart.

Comment 2

[Dan M]

Attachment: force entire window onscreen when loading persistent size and position

Comment 3

[Dan M]

The above patch is raising eyebrows on people who don't want the entire window 
forced onscreen. Which is fine by me. A new patch is just below. While the 
Platform field on this bug says "All," as far as I can tell, it's only really a 
problem on the Mac. That's because the window is only barely forced onscreen and 
the menubar isn't taken into account, so it ends up slightly offscreen. The below 
patch leaves it as is (windows not forced entirely onscreen) but forces them a 
little more onscreen (the old 10 pixels wasn't much and was probably being 
missed) and is generally more careful on the Mac.

Comment 4

[Dan M]

Attachment: less drastic than above. larger slop and take menubar into account on the Mac

Comment 5

[Christopher Blizzard (:blizzard)]

This one is fine with me.

Comment 6

[Dan M]

r=pchen sr=hyatt

Comment 7

[Dan M]

The second patch is in. I reiterate that although this bug complains about a 
problem on all platforms, as far as I can tell, it was really only a problem on 
the Mac. Other platforms successfully forced a window onscreen, though only by a 
10 pixel margin. That's probably easily missed. On the Mac the window was truly 
completely offscreen, because the forcing code wasn't taking the menubar into 
account. The patch checked in bumps the margin to 20 pixels, making the window 
easier to spot, and also on the Mac bumps the window up by the height of the 
menubar.

Comment 8

[John Morrison]

verified fixed, mac (and win2k, just for the heck of it), per sairuh's test 
above. dialog is back on screen by ~20px.