767905 - device storage - Move editable flag into DeviceStorageFile

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Doug Turner (:dougt)]

Current we are passing around a 'editable' flag in prep for 757724.  Everywhere we use this flag, we also have a DeviceStorageFile.  Lets move the flag there so that we have less to pass around.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 636259 [details] [diff] [review]
patch v.1

Review of attachment 636259 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/devicestorage/nsDeviceStorage.cpp
@@ +27,5 @@
>  public:
>  
>    nsCOMPtr<nsIFile> mFile;
>    nsString mPath;
> +  bool mEditable;

Huh, these are all public?

@@ +59,5 @@
>      NormalizeFilePath();
>    }
>  
> +  void
> +  setEditable(bool aEditable) {

Hm, everywhere you call this you do so right after constructing the object. Does it make more sense to just make this a constructor arg?

@@ +391,5 @@
>    {
>      BuildErrorString(aMessage, aFile);
>    }
>  
> +  PostErrorEvent(DOMRequest* aRequest, const nsAString& aErrorMessage)

This change looks unrelated?

Comment 3

[Doug Turner (:dougt)]

> Huh, these are all public?

yes. 

> Hm, everywhere you call this you do so right after constructing the object. Does it make more sense to just make this a constructor arg?

not everywhere.  the default is not editable.

> This change looks unrelated?

removed locally.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 636259 [details] [diff] [review]
patch v.1

Review of attachment 636259 [details] [diff] [review]:
-----------------------------------------------------------------

Ok.

Comment 5

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c707e4f15fd4

Comment 6

[Ed Morley [:emorley]]

Push backed out for devicestorage test failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c707e4f15fd4
https://tbpl.mozilla.org/php/getParsedLog.php?id=13002287&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/610161cc263b

Comment 7

[Doug Turner (:dougt)]

again:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/2830e6de596c

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2830e6de596c