767919 - Crash in nsStringBuffer::Realloc() during Feed sniffing. Properly enforce the sniffing limit on uncompressed feeds.

Status: RESOLVED DUPLICATE of bug 794067

(SeaMonkey :: Feed Discovery and Preview, defect)

Description

[Philip Chee]

Our feed sniffing code is copied from Firefox so we mostly suffer from the same bugs. Firefox fixed their crash in Bug 739040. We should do the same.

The Firefox patches are in attachment 616954 [details] [diff] [review] and attachment 617186 [details] [diff] [review].
MXR says our code is somewhere here:
<http://mxr.mozilla.org/comm-central/search?string=GetMIMETypeFromContent&find=%2Fsuite%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central>

Note need to port the changes in attachment 617186 [details] [diff] [review] to the tests as well so that things remain in sync.

Comment 1

[Madhavan]

Hi, 
Can i have this bug assigned to me?

Comment 2

[Philip Chee]

> Can i have this bug assigned to me?
Sure. Go Ahead!

Comment 3

[Madhavan]

Hi, 
The bug shows that the mentor is Neil.
How may i get in contact with him?

Comment 4

[Philip Chee]

https://wiki.mozilla.org/Modules/SeaMonkey
Neil Rashbrook. You can contact him on IRC irc://moznet/seamonkey . His nick is usually NeilAway

Comment 5

[Philip Chee]

Hi Madhavan! Any progress to report? What can we do to help you move this bug forward?

Comment 6

[Philip Chee]

Hello Madhavan! Any progress to report?

Comment 7

[Philip Chee]

No reply. Unassigning.

Comment 8

[Mayuresh Raut]

If Madhavan is not interested, I would like to work on this bug. Let me know how to proceed.

Comment 9

[Philip Chee]

Mayuresh, sure no problem, just go ahead. Have you checked out the Mercurial repository for comm-central? http://hg.mozilla.org/comm-central/ ?
Have you read the simple build instructions?
https://developer.mozilla.org/en-US/docs/Simple_SeaMonkey_build
Please join us on IRC where most of the developer discussions take place:
irc://irc.mozilla.org/seamonkey .

Comment 10

[SADINENI RAVI CHANDRA]

if mayuresh is not interested in this project i am ready to work on it ... can u please inttimate me if i can proceed ...

Comment 11

[Philip Chee]

Mayuresh got here first.

Comment 12

[Philip Chee]

Hi Mayuresh,

I don't know much about Ubuntu but instead of:
  sudo apt-get build-dep seamonkey
Try running the following two commands:
  sudo apt-get build-dep firefox
  sudo apt-get build-dep thunderbird

Comment 13

[Mayuresh Raut]

Hello Philip,

I tried building seamonkey on ubuntu 12.4 as well as Fedora 17. I get the below error for both the OS's. Is this any known issue?


/home/mayuresh/comm-central/mailnews/base/src/nsMessenger.cpp: In member function ‘virtual nsresult nsSaveMsgListener::OnDataAvailable(nsIRequest*, nsISupports*, nsIInputStream*, PRUint32, PRUint32)’:
/home/mayuresh/comm-central/mailnews/base/src/nsMessenger.cpp:1908:40: error: no matching function for call to ‘nsIInputStream::Available(PRUint32*)’
/home/mayuresh/comm-central/mailnews/base/src/nsMessenger.cpp:1908:40: note: candidate is:
../../../mozilla/dist/include/nsIInputStream.h:66:14: note: virtual nsresult nsIInputStream::Available(PRUint64*)
../../../mozilla/dist/include/nsIInputStream.h:66:14: note:   no known conversion for argument 1 from ‘PRUint32* {aka unsigned int*}’ to ‘PRUint64* {aka long unsigned int*}’
make[6]: *** [nsMessenger.o] Error 1
make[6]: Leaving directory `/home/mayuresh/comm-central/objdir-sm-release/mailnews/base/src'
make[5]: *** [src_libs] Error 2
make[5]: Leaving directory `/home/mayuresh/comm-central/objdir-sm-release/mailnews/base'
make[4]: *** [libs_tier_platform] Error 2
make[4]: Leaving directory `/home/mayuresh/comm-central/objdir-sm-release/mozilla'
make[3]: *** [tier_platform] Error 2
make[3]: Leaving directory `/home/mayuresh/comm-central/objdir-sm-release/mozilla'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/home/mayuresh/comm-central/objdir-sm-release/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/mayuresh/comm-central/objdir-sm-release'
make: *** [build] Error 2

Thanks,
Mayuresh

Comment 14

[Philip Chee]

Yes, this is Bug 781943 - [Azure] gfx::2d should be able to deal with nullptrs
That bug has a patch with review. Probably will be checked in tomorrow.

> sudo apt-get build-dep thunderbird
Did this work? I just remembered that Ubuntu removed SeaMonkey from 12.4 so I guess the build dependencies aren't there either.

Comment 15

[Mayuresh Raut]

Hello Philip,

apt-get build-deb thunderbird worked and I was able to build seamonkey on ubuntu12.4. Can you please help me to get started and locate the file to work on.

Thanks,
Mayuresh

Comment 16

[Philip Chee]

Sure. We need to port https://hg.mozilla.org/mozilla-central/rev/38110d344363

Our code lives here:
http://mxr.mozilla.org/comm-central/source/suite/feeds/src/nsFeedSniffer.cpp

Approximately at the following lines:
http://hg.mozilla.org/comm-central/annotate/aba9ee720457/suite/feeds/src/nsFeedSniffer.cpp#l37
and
http://hg.mozilla.org/comm-central/annotate/aba9ee720457/suite/feeds/src/nsFeedSniffer.cpp#l285

Comment 17

[Philip Chee]

In the meantime I fixed this as part of Bug 794067 - Sync Feed Preview with Firefox as at 2012/09