Closed Bug 767957 Opened 11 years ago Closed 11 years ago

Dead code checks for shistory in nsDocShell::AddState

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Details

Attachments

(1 file)

Patch v1
1.32 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
This is causing https://github.com/mozilla-b2g/gaia/issues/1869#issuecomment-6520055

Exactly why they're calling history.replaceState with no shistory object is...unclear.  Calling replaceState is kind of sane, but pushState with no shistory is pretty worrying and probably not what they want.

This code is still dead, though.  We could leave in the (accidental) assertion that there's a root shistory object for pushState, if you want.

Patch once I have it tested...
Attached patch Patch v1 — — Splinter Review 

        Attachment #636309 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 636309 [details] [diff] [review]
Patch v1

r=me

        Attachment #636309 -
        Flags: review?(bzbarsky) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/00bef3ccdd2b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

          You need to log in
          before you can comment on or make changes to this bug.