Last Comment Bug 767957 - Dead code checks for shistory in nsDocShell::AddState
: Dead code checks for shistory in nsDocShell::AddState
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Justin Lebar (not reading bugmail)
: Andrew Overholt [:overholt]
Depends on:
  Show dependency treegraph
Reported: 2012-06-25 06:10 PDT by Justin Lebar (not reading bugmail)
Modified: 2012-06-27 03:37 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (1.32 KB, patch)
2012-06-25 07:51 PDT, Justin Lebar (not reading bugmail)
bzbarsky: review+
Details | Diff | Splinter Review

Description Justin Lebar (not reading bugmail) 2012-06-25 06:10:03 PDT
This is causing

Exactly why they're calling history.replaceState with no shistory object is...unclear.  Calling replaceState is kind of sane, but pushState with no shistory is pretty worrying and probably not what they want.

This code is still dead, though.  We could leave in the (accidental) assertion that there's a root shistory object for pushState, if you want.

Patch once I have it tested...
Comment 1 Justin Lebar (not reading bugmail) 2012-06-25 07:51:12 PDT
Created attachment 636309 [details] [diff] [review]
Patch v1
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2012-06-25 08:35:18 PDT
Comment on attachment 636309 [details] [diff] [review]
Patch v1

Comment 3 Justin Lebar (not reading bugmail) 2012-06-26 08:20:45 PDT
Comment 4 Ed Morley [:emorley] 2012-06-27 03:37:02 PDT

Note You need to log in before you can comment on or make changes to this bug.