Dead code checks for shistory in nsDocShell::AddState

RESOLVED FIXED in mozilla16

Status

()

Product:
Core
Component:
Document Navigation
Status:
RESOLVED FIXED
Reported:
7 years ago
Modified:
7 years ago

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Tracking

Version:
Trunk
Target:
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Patch v1
1.32 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
7 years ago 
This is causing https://github.com/mozilla-b2g/gaia/issues/1869#issuecomment-6520055

Exactly why they're calling history.replaceState with no shistory object is...unclear.  Calling replaceState is kind of sane, but pushState with no shistory is pretty worrying and probably not what they want.

This code is still dead, though.  We could leave in the (accidental) assertion that there's a root shistory object for pushState, if you want.

Patch once I have it tested...
(Assignee)

Comment 1

•
7 years ago
Posted patch Patch v1 — — Splinter Review 

        Attachment #636309 -
        Flags: review?(bzbarsky)

    
    

      

        



        		

        



        		

        

          
        

      


      

        
          

            Comment 2
          

          •
          
7 years ago
          

        		
      


      

        
        
      

    


    
  
Comment on attachment 636309 [details] [diff] [review]
Patch v1

r=me

        Attachment #636309 -
        Flags: review?(bzbarsky) → review+

    
    

      

        



        		

        



        		

        

          
        

      


      

        
          

            Comment 4
          

          •
          
7 years ago
          

        		
      


      

        
        
      

    


    
  
https://hg.mozilla.org/mozilla-central/rev/00bef3ccdd2b
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

          You need to log in
          before you can comment on or make changes to this bug.