The default bug view has changed. See this FAQ.

Dead code checks for shistory in nsDocShell::AddState

RESOLVED FIXED in mozilla16

Status

()

Core
Document Navigation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This is causing https://github.com/mozilla-b2g/gaia/issues/1869#issuecomment-6520055

Exactly why they're calling history.replaceState with no shistory object is...unclear.  Calling replaceState is kind of sane, but pushState with no shistory is pretty worrying and probably not what they want.

This code is still dead, though.  We could leave in the (accidental) assertion that there's a root shistory object for pushState, if you want.

Patch once I have it tested...
(Assignee)

Comment 1

5 years ago
Created attachment 636309 [details] [diff] [review]
Patch v1
Attachment #636309 - Flags: review?(bzbarsky)
Comment on attachment 636309 [details] [diff] [review]
Patch v1

r=me
Attachment #636309 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/00bef3ccdd2b
Assignee: nobody → justin.lebar+bug
https://hg.mozilla.org/mozilla-central/rev/00bef3ccdd2b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.