Last Comment Bug 767957 - Dead code checks for shistory in nsDocShell::AddState
: Dead code checks for shistory in nsDocShell::AddState
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Justin Lebar (not reading bugmail)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-25 06:10 PDT by Justin Lebar (not reading bugmail)
Modified: 2012-06-27 03:37 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.32 KB, patch)
2012-06-25 07:51 PDT, Justin Lebar (not reading bugmail)
bzbarsky: review+
Details | Diff | Splinter Review

Description Justin Lebar (not reading bugmail) 2012-06-25 06:10:03 PDT
This is causing https://github.com/mozilla-b2g/gaia/issues/1869#issuecomment-6520055

Exactly why they're calling history.replaceState with no shistory object is...unclear.  Calling replaceState is kind of sane, but pushState with no shistory is pretty worrying and probably not what they want.

This code is still dead, though.  We could leave in the (accidental) assertion that there's a root shistory object for pushState, if you want.

Patch once I have it tested...
Comment 1 Justin Lebar (not reading bugmail) 2012-06-25 07:51:12 PDT
Created attachment 636309 [details] [diff] [review]
Patch v1
Comment 2 Boris Zbarsky [:bz] (TPAC) 2012-06-25 08:35:18 PDT
Comment on attachment 636309 [details] [diff] [review]
Patch v1

r=me
Comment 3 Justin Lebar (not reading bugmail) 2012-06-26 08:20:45 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/00bef3ccdd2b
Comment 4 Ed Morley [:emorley] 2012-06-27 03:37:02 PDT
https://hg.mozilla.org/mozilla-central/rev/00bef3ccdd2b

Note You need to log in before you can comment on or make changes to this bug.