767957 - Dead code checks for shistory in nsDocShell::AddState

Status: RESOLVED FIXED

Description

[Justin Lebar (not reading bugmail)]

This is causing https://github.com/mozilla-b2g/gaia/issues/1869#issuecomment-6520055

Exactly why they're calling history.replaceState with no shistory object is...unclear.  Calling replaceState is kind of sane, but pushState with no shistory is pretty worrying and probably not what they want.

This code is still dead, though.  We could leave in the (accidental) assertion that there's a root shistory object for pushState, if you want.

Patch once I have it tested...

Comment 1

[Justin Lebar (not reading bugmail)]

Created attachment 636309 [details] [diff] [review]
Patch v1

Comment 2

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

Comment on attachment 636309 [details] [diff] [review]
Patch v1

r=me

Comment 3

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00bef3ccdd2b

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/00bef3ccdd2b