The default bug view has changed. See this FAQ.

IonMonkey: Don't monitor the stack value for non-ResumeAfter bailouts

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 636317 [details] [diff] [review]
Patch

decoder reported a testcase on IRC where the overrecursion check triggered a GC + invalidaton. The first opcode in the script was JSOP_GETGNAME so InvalidationBailout tried to monitor the value on top of the stack and we'd crash.

The fix is to only monitor the value for resumeAfter bailouts - in all other cases the value on the stack is invalid and we will just redo the op in the interpreter.
Attachment #636317 - Flags: review?(dvander)
Attachment #636317 - Flags: review?(dvander) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/80a4e5dfeaaf
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Duplicate of this bug: 758167
You need to log in before you can comment on or make changes to this bug.