Closed Bug 768004 Opened 12 years ago Closed 12 years ago

IonMonkey: Don't monitor the stack value for non-ResumeAfter bailouts

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
decoder reported a testcase on IRC where the overrecursion check triggered a GC + invalidaton. The first opcode in the script was JSOP_GETGNAME so InvalidationBailout tried to monitor the value on top of the stack and we'd crash.

The fix is to only monitor the value for resumeAfter bailouts - in all other cases the value on the stack is invalid and we will just redo the op in the interpreter.
Attachment #636317 - Flags: review?(dvander)
Attachment #636317 - Flags: review?(dvander) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/80a4e5dfeaaf
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.