76803 - eliminate use of NS_DECLARE_ID in mozilla/intl code

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P3)

Description

[Chris Waterson]

...since this contributes to much pain and suffering, and causes many duplicate
symbols to be defined.

Comment 1

[Chris Waterson]

Taking bug, since I have patches. Roy, can you r=?

Comment 2

[Chris Waterson]

Attachment: clean up global symbols in mozilla/intl

Comment 3

[Chris Waterson]

The #define's for the g_InstanceCount and g_LockCount are pretty unsightly. It's
a shame we don't have this stuff macro-ized out and integrated with nsIModule,
but, ...

Comment 4

[Andreas Becker]

Chnaging QA contact to ftang for now.

Comment 5

[Chris Waterson]

Actually, it turns out we cannot land the |#define g_InstanceCount| cruft 
onto the trunk as is (although the rest of the stuff can stay the same). It 
causes missing symbols in a dynamic build.

Comment 6

[Roy Yokoyama]

Looks pretty good :-)
To improve the readability, can you change //uconv/ucvko/nsUCvKODll.h
 from 
   extern "C" PRUint16 g_utKSC5601Mapping[];
   extern "C" PRUint16 g_ufKSC5601Mapping[];
+#define g_AsciiMapping ucvko_g_AsciiMapping
   extern "C" PRUint16 g_AsciiMapping[];
   extern "C" PRUint16 g_HangulNullMapping[];
  to
+#define g_AsciiMapping ucvko_g_AsciiMapping
   extern "C" PRUint16 g_utKSC5601Mapping[];
   extern "C" PRUint16 g_ufKSC5601Mapping[];

/r=yokoyama with above change.

Comment 7

[Chris Waterson]

roy: I don't want to check in the #define's right now: it turns out that they 
screw up the dynamic build. I'm going to have to figure out a better way to deal 
with these things.

Comment 8

[Roy Yokoyama]

Understood.

Comment 9

[Chris Waterson]

See bug 77209, which deals specifically with duplicate g_InstanceCount and 
g_LockCount variables.

Comment 10

[Chris Waterson]

dprice: this patch should pretty much be ready-to-wear. Needs final sign-off
from ftang. Probably should land this in conjunction with the patch in bug
77209.

Comment 11

[dprice (gone)]

-> kandrot

Comment 12

[Edward Kandrot]

Checked this in last week as part of the Ron Guilmette merge,