768079 - "ASSERTION: How did we end up with a 3D transform here?!"

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: How did we end up with a 3D transform here?!: 'isMask2D', file gfx/layers/opengl/LayerManagerOGLProgram.cpp, line 349

This instance of this assertion was added in bug 716439.

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Nick Cameron [:nrc]]

Having a transform and border radius on the body tag leads to a Thebes layer with a 3D transform and a mask layer. That is not an expected combination, so causes the assertion (indirectly because Thebes layers calculate an effective transformation differently from container layers, which is where 3D transforms are usually dealt with). I'll try to find a fix.

Comment 3

[Nick Cameron [:nrc]]

Attachment: fix

Comment 4

[Nick Cameron [:nrc]]

Attachment: test

Comment 5

[Nick Cameron [:nrc]]

Attachment: test

Comment 6

[Nick Cameron [:nrc]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=1209bfaff4b9

Comment 7

[Nick Cameron [:nrc]]

Comment on attachment 636583 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 716439
User impact if declined: possible incorrect rendering
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): no obvious risks
String or UUID changes made by this patch: none

Comment 8

[Nick Cameron [:nrc]]

Comment on attachment 636586 [details] [diff] [review]
test

[Approval Request Comment]
test, see approval request comment above

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1766d4a0c876
https://hg.mozilla.org/mozilla-central/rev/1209bfaff4b9

Comment 10

[Nick Cameron [:nrc]]

https://tbpl.mozilla.org/?tree=Mozilla-Aurora&rev=771d99dd1dd8

Comment 11

[Scoobidiver (away)]

Did it land in Aurora?

Comment 12

[Nick Cameron [:nrc]]

Yes, comment 10, I'm pretty sure it stuck.