Last Comment Bug 768138 - EncNoDeclaration string contains a grammatical error
: EncNoDeclaration string contains a grammatical error
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: HTML: Parser (show other bugs)
: unspecified
: All All
: -- trivial (vote)
: mozilla17
Assigned To: Henri Sivonen (:hsivonen)
:
Mentors:
Depends on: 672453
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-25 11:45 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-08-05 08:48 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Zap the bogus "to" (6.38 KB, patch)
2012-07-13 05:40 PDT, Henri Sivonen (:hsivonen)
l10n: review-
Details | Diff | Review
Zap the bogus "to", v2 (3.60 KB, patch)
2012-08-02 05:00 PDT, Henri Sivonen (:hsivonen)
bugs: review+
Details | Diff | Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2012-06-25 11:45:03 PDT
"The character encoding of the page must to be declared in the document or in the transfer protocol."

s/must to be/must be/
Comment 1 Henri Sivonen (:hsivonen) 2012-07-13 05:40:49 PDT
Created attachment 641838 [details] [diff] [review]
Zap the bogus "to"

It's unclear to me if the string should get a new id in this case. Should it?
Comment 2 Henri Sivonen (:hsivonen) 2012-07-23 03:07:40 PDT
Comment on attachment 641838 [details] [diff] [review]
Zap the bogus "to"

Whoa. The earlier review request went nowhere. Trying again.
Comment 3 Axel Hecht [:Pike] 2012-07-23 04:04:55 PDT
Comment on attachment 641838 [details] [diff] [review]
Zap the bogus "to"

Review of attachment 641838 [details] [diff] [review]:
-----------------------------------------------------------------

This is just a grammar fix, that doesn't need a key change. When the en-US string is really just wrong grammar, and doesn't change meaning, it's fine to just change the value.
Comment 4 Henri Sivonen (:hsivonen) 2012-08-02 05:00:08 PDT
Created attachment 648314 [details] [diff] [review]
Zap the bogus "to", v2
Comment 5 Henri Sivonen (:hsivonen) 2012-08-05 06:30:37 PDT
Thanks for the r+.
https://hg.mozilla.org/integration/mozilla-inbound/rev/85872a2e11db
Comment 6 Ed Morley [:emorley] 2012-08-05 08:48:30 PDT
https://hg.mozilla.org/mozilla-central/rev/85872a2e11db

Note You need to log in before you can comment on or make changes to this bug.