768190 - Dictionary members should not allow [TreatNullAs] or [TreatUndefinedAs] annotations

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Spec says so.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Honestly, unless this is really easy to implement in the parser (and it's not clear that it would be), I don't think we should bother.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't allow [TreatNullAs] or [TreatUndefinedAs] on dictionary members.

Comment 3

[Boris Zbarsky [:bzbarsky]]

See above: pretty trivial to implement, imo.

Comment 4

[Justin Lebar (not reading bugmail)]

Comment on attachment 636473 [details] [diff] [review]
Don't allow [TreatNullAs] or [TreatUndefinedAs] on dictionary members.

> class IDLArgument(IDLObjectWithIdentifier):
>-    def __init__(self, location, identifier, type, optional=False, defaultValue=None, variadic=False):
>+    def __init__(self, location, identifier, type, optional=False, defaultValue=None, variadic=False, dictionaryMember=False):
>         IDLObjectWithIdentifier.__init__(self, location, None, identifier)
> 
>         assert isinstance(type, IDLType)
>         self.type = type
> 
>         if defaultValue:
>             defaultValue = defaultValue.coerceToType(type, location)
>             assert defaultValue
> 
>         self.optional = optional
>         self.defaultValue = defaultValue
>         self.variadic = variadic
>+        self.dictionaryMember = dictionaryMember
> 
>         assert not variadic or optional
> 
>     def addExtendedAttributes(self, attrs):
>+        if self.dictionaryMember:
>+            for (attr, value) in attrs:
>+                if attr == "TreatUndefinedAs":
>+                    raise WebIDLError("[TreatUndefinedAs] is not allowed for "
>+                                      "dictionary members", [self.location])
>+                elif attr == "TreatNullAs":
>+                    raise WebIDLError("[TreatNullAs] is not allowed for "
>+                                      "dictionary members", [self.location])

This could be just |if 'TreatUndefinedAs' in attrs| and so on.

Comment 5

[Boris Zbarsky [:bzbarsky]]

> This could be just |if 'TreatUndefinedAs' in attrs| and so on.

Attrs is a list of tuples, so I'm not sure it could.

Comment 6

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41412974ed77

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/41412974ed77