768191 - Excise Honeycomb and Gingerbread Android themes from Metro

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Jonathan Wilde [:jwilde]]

Given that Metro will likely never run on Android, the honeycomb and gingerbread folders should probably be removed from browser/metro/theme, along with their corresponding entries in browser/metro/theme/jar.mn.

Comment 1

[Jonathan Wilde [:jwilde]]

Attachment: Bug 768191 Excise Honeycomb and Gingerbread Android themes from Metro

Comment 2

[Jim Mathies [:jimm]]

Does the ui work with these changes or is landing this dependent on new ui work TBD?

Comment 3

[Jonathan Wilde [:jwilde]]

The UI will still work.  Fennec XUL shipped with three themes:

1. A theme that covers Froyo, Android <2.3, and platforms other than Android (Maemo, Metro, etc.)
2. A theme for Gingerbread
3. A theme for Honeycomb

During Windows builds, theme #1 is the only one that currently is enabled.  This patch removes themes #2 and #3, but leaves #1 intact.

Comment 4

[Brian R. Bondy [:bbondy]]

Comment on attachment 636482 [details] [diff] [review]
Bug 768191 Excise Honeycomb and Gingerbread Android themes from Metro

Review of attachment 636482 [details] [diff] [review]:
-----------------------------------------------------------------

for elm

Comment 5

[Jonathan Wilde [:jwilde]]

On elm (http://hg.mozilla.org/projects/elm/rev/345244b84531).

Comment 6

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.