76820 - Xlib-toolkit does not render images correctly...

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Roland Mainz]

Xlib-toolkit based Mozilla build from 2001-04-17 CVS snapshot does not render
images correctly - and at the same time it spamms the log with
"nsImageXlib::DrawToImage not yet implemented: 'Not Reached'" messages. It looks
that the not-yet-implemented function nsImageXlib::DrawToImage() is responsible
for this problem... ;-(

CC:'ing pavlov as he wrong the code for GTK+-toolkit and [e-mail]
for the partial implementation for Xlib-toolkit...

Comment 1

[Roland Mainz]

Attachment: Screenshot showing Xlib-based Mozilla rendering images wrong

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I tried to actually fix that implementation, and I'll attach what I've done so
far.  However, it doesn't actually help at all...

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: my failed attempt to fix this

Comment 4

[Peter Trudelle]

->blizzard

Comment 5

[Roland Mainz]

Uhm... after looking twice on that code...
What about creating a XImage from incoming nsIImage, run XSubImage() (and care
about alpha stuff if required) and pass contents of resulting XImage back to
destination...

blizzard.... do you see any problems with that idea ?

Comment 6

[pocemit]

There are some fixes for image drawing attached to bug #66082 as part of xlib
gc-cache update.

Comment 7

[pocemit]

Fix in bug 66082

Comment 8

[pocemit]

Now that bug 66082 is in, here are additional fixes to sync nsImageXlib with the
GTK version and fix nearly *all* image related problems :)

Comment 9

[pocemit]

Attachment: nsImageXlib.cpp updates for scaled and animated images

Comment 10

[pocemit]

gisburn: can you give this a couple tests on your build and see how it works?
This should fix some 1x1 scaled transparent gif issues and also a couple typos I
had in bug 66082

Comment 11

[pocemit]

Attachment: removed some tabs and commented out code I forgot

Comment 12

[pocemit]

Attachment: Tomi pointed out a missing IsSpacer check

Comment 13

[Tomi Leppikangas]

Lates patch looks good and works ok. Patch is just collection of gtk
changes ported to xlib. r=tomilepp

Comment 14

[pocemit]

Sorry about this, but I have noticed you gave out sr= on some other Xlib related
stuff, so I thought I would send this your way.

This is mostly a cut & paste from ImageGTK to bring it in sync, plus a couple
typos fixes from my last patch.

Comment 15

[Darin Fisher]

rs=darin

Comment 16

[timeless]

ok, will check in

Comment 17

[timeless]

fix checked in, thanks

Comment 18

[pocemit]

Looks good here with latest xlib-toolkit build