768205 - Marketplace Manifest Validator fails validation for manifests containing the new 'appcache_path' attribute

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect)

Description

[(not reading bugmail) Nick Desaulniers [:\n]]

From Ticket #760365 <https://bugzilla.mozilla.org/show_bug.cgi?id=760365>, the dev marketplace will fail any new app submissions that contain the new "appcache_path" attribute:
Unknown property found.

Error: An unknown property was found in the webapp manifest.

Error: Found property: appcache_path

Comment 1

[Christopher Van Wiemeersch [:cvan]]

So I see this property in this manifest — http://people.mozilla.com/~fdesre/openwebapps/app.manifest — but I don't see it in the spec: http://mozilla.github.com/webapps-spec/

Is this in line with the spec?

Comment 2

[Jason Smith [:jsmith]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #1)
> So I see this property in this manifest —
> http://people.mozilla.com/~fdesre/openwebapps/app.manifest — but I don't see
> it in the spec: http://mozilla.github.com/webapps-spec/
> 
> Is this in line with the spec?

We probably need to get that up to date. Nick updated the dev docs here - https://developer.mozilla.org/en/Apps/Manifest

Comment 3

[Jason Smith [:jsmith]]

Nom for k9o and basecamp - needed in order to allow listing of apps on marketplace that use preloading of app cache on web apps install. The corresponding bugs were blockers, so this should be a blocker as well.

See bug 702369 and bug 760365.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

(In reply to Jason Smith [:jsmith] from comment #2)
> > Is this in line with the spec?
> 
> We probably need to get that up to date. Nick updated the dev docs here -
> https://developer.mozilla.org/en/Apps/Manifest

This appears twice in the example:

  "appcache_path": "/cache.manifest",  
...
  "appcache_path": "/manifest.webapp"

Comment 5

[Jason Smith [:jsmith]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #4)
> (In reply to Jason Smith [:jsmith] from comment #2)
> > > Is this in line with the spec?
> > 
> > We probably need to get that up to date. Nick updated the dev docs here -
> > https://developer.mozilla.org/en/Apps/Manifest
> 
> This appears twice in the example:
> 
>   "appcache_path": "/cache.manifest",  
> ...
>   "appcache_path": "/manifest.webapp"

Fixed. Only referencing /cache.manifest now.

Comment 6

[Anant Narayanan [:anant]]

The property is legit, I just tweaked the MDN docs a bit and updated the spec to include it.

Comment 7

[Matt Basta [:basta]]

https://github.com/mozilla/amo-validator/pull/160

Comment 8

[Matt Basta [:basta]]

Merged

Comment 9

[(not reading bugmail) Nick Desaulniers [:\n]]

I'm still getting this error on: https://marketplace-dev.allizom.org/en-US/developers/submit/app/manifest ???

Comment 10

[Matt Basta [:basta]]

Nick: This isn't in production yet. It should get pushed next Thursday.

Comment 11

[krupa raj[:krupa]]

(In reply to Nick Desaulniers [:\n] from comment #9)
> I'm still getting this error on:
> https://marketplace-dev.allizom.org/en-US/developers/submit/app/manifest ???

Works on -dev with http://addax5313.testmanifest.com/manifest.webapp. Can you try again?

Comment 12

[(not reading bugmail) Nick Desaulniers [:\n]]

Working now!

Comment 13

[Jason Smith [:jsmith]]

Not an on-device bug. Removing nom.