Closed Bug 768222 Opened 10 years ago Closed 10 years ago

Make pprint-color the default logging format for Mozmill

Categories

(Testing Graveyard :: Mozmill, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

Details

(Whiteboard: [mozmill-2.0])

Attachments

(2 files)

Pure JSON output for the Mozmill CLI tool is not the right solution. It's obvious that this output is hard to read by any tester who is running the tool manually. For automation tools we should enforce that those have to set the --format option to JSON if they really need JSON output.
Attached file Patch
Pointer to Github pull-request
Attachment #636495 - Attachment description: Pointer to Github pull request: https://github.com/mozautomation/mozmill/pull/58 → Patch
Attachment #636495 - Flags: review?(jhammel)
Attachment #636495 - Flags: review?(jhammel) → review?(ctalbert)
Attachment #636495 - Flags: review?(ctalbert) → review+
https://github.com/mozautomation/mozmill/commit/d37c5d6e64a93cbf195deec972fd32be32529a99
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-2.0]
Pointer to Github pull-request
Comment on attachment 637552 [details]
Follow-up for class instances

Sorry that I have missed that but while working on the automation scripts I have seen that we didn't use the pprint_color mode when the LoggerListener gets instantiated.
Attachment #637552 - Attachment description: Pointer to Github pull request: https://github.com/mozautomation/mozmill/pull/60/files → Follow-up for class instances
Attachment #637552 - Flags: review?(ctalbert)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #637552 - Flags: review?(ctalbert) → review+
https://github.com/mozautomation/mozmill/commit/a50e0c82bf64a89a9bb488d079d896dc82b15b42
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.