Last Comment Bug 768381 - [OS.File] More bugs to fix
: [OS.File] More bugs to fix
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: File (show other bugs)
: unspecified
: All All
: -- trivial (vote)
: mozilla16
Assigned To: David Rajchenbach-Teller [:Yoric] (please use "needinfo")
:
Mentors:
Depends on:
Blocks: 764436
  Show dependency treegraph
 
Reported: 2012-06-26 02:55 PDT by David Rajchenbach-Teller [:Yoric] (please use "needinfo")
Modified: 2012-06-28 01:07 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Defining mode_t correctly (3.27 KB, patch)
2012-06-26 02:57 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
dteller: review+
Details | Diff | Splinter Review
Defining mode_t correctly (5.81 KB, patch)
2012-06-26 06:06 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
dteller: review+
Details | Diff | Splinter Review
OS.Constants.Sys.Version should be OS.Constants.Sys.Name (828 bytes, patch)
2012-06-27 03:00 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
dteller: review+
Details | Diff | Splinter Review

Description David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-06-26 02:55:25 PDT

    
Comment 1 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-06-26 02:57:44 PDT
Created attachment 636642 [details] [diff] [review]
Defining mode_t correctly
Comment 2 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-06-26 06:06:33 PDT
Created attachment 636674 [details] [diff] [review]
Defining mode_t correctly
Comment 3 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-06-27 03:00:05 PDT
Created attachment 637054 [details] [diff] [review]
OS.Constants.Sys.Version should be OS.Constants.Sys.Name
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-06-27 17:27:19 PDT
Not a huge fan of checking in self-reviewed patches, by the way...

https://hg.mozilla.org/integration/mozilla-inbound/rev/d37010874d5f
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb01d0556cdc
Comment 5 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-06-28 00:23:26 PDT
I can understand that. I will try and avoid this in the future.

Thanks for the check-in.

Note You need to log in before you can comment on or make changes to this bug.