768386 - Make Android Armv6 builds distinguishable from standard opt native Android builds on TBPL

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

Both the standard native Android opt builds and armv6 builds show up on the "Android opt" rows on TBPL, both as 'B'. This makes it harder to tell them apart after clobbering/retriggering (without looking at the build info bottom left) - and every time I see the double 'B' I think it's been retriggered one two many times.

We could:

a) Map 'Android Armv6 mozilla-* build' to 'Bv6' (or similar)

b) Stick it on it's own 'Android Armv6 opt' row

I'm inclined to favour A.

Comment 1

[[e-mail] (:bhearsum)]

I just did this for B2G, should be an easy patch.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: separate row for armv6

I think B) is much more inline with what we do already -- each row is its own platform + configuration (with exceptions for Desktop-variants like RPM builds). We could do A), I guess, but I'd really like to stay as consistent as we can.

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 636795 [details] [diff] [review]
separate row for armv6

Review of attachment 636795 [details] [diff] [review]:
-----------------------------------------------------------------

Data.js needs a small fixup, but tested locally with that and works great :-)
r=me with that change.

::: js/Data.js
@@ +494,4 @@
>          /WINNT 6\.1/i.test(name) ? "windows" :
>          /WINNT 5\.2/i.test(name) ? "windows" :
>          /android xul/i.test(name) ? "android-xul" :
> +        /android armv6/i.test(name) ? "android-armv6

Missing closing quote and colon.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 636795 [details] [diff] [review]
separate row for armv6

Landed, with the syntax fixed: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/bc556afd4a02

Waiting to see how things look in staging before asking for a production push.

Comment 5

[[e-mail] (:bhearsum)]

Looks fine in staging, waiting until https://bugzilla.mozilla.org/show_bug.cgi?id=769018 is ready before requesting a push.

Comment 6

[Ed Morley [:emorley]]

Deployed to prod :-)