768409 - [Crash @copyBuffer()] OOM when copying screenshot buffers

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

edmorely pointed this out to me on irc and from the log it looks like we're OOM'ing when copying from one screenshot buffer to another. Unless I'm mistaken, there's no reason for this not to just be a strait memcpy. 

https://tbpl.mozilla.org/php/getParsedLog.php?id=12981786&full=1&branch=mozilla-inbound

I/dalvikvm-heap( 1701): Forcing collection of SoftReferences for 1602852-byte allocation
E/dalvikvm-heap( 1701): Out of memory on a 1602852-byte allocation.
E/GeckoAppShell( 1701): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 9 ("GeckoBackgroundThread")
E/GeckoAppShell( 1701): java.lang.OutOfMemoryError
E/GeckoAppShell( 1701): 	at java.nio.ByteBuffer.put(ByteBuffer.java:815)
E/GeckoAppShell( 1701): 	at org.mozilla.gecko.gfx.ScreenshotLayer$ScreenshotImage.copyBuffer(ScreenshotLayer.java:138)
E/GeckoAppShell( 1701): 	at org.mozilla.gecko.gfx.ScreenshotLayer$ScreenshotImage.setBitmap(ScreenshotLayer.java:144)
E/GeckoAppShell( 1701): 	at org.mozilla.gecko.gfx.ScreenshotLayer.setBitmap(ScreenshotLayer.java:53)
E/GeckoAppShell( 1701): 	at org.mozilla.gecko.gfx.LayerRenderer.setCheckerboardBitmap(LayerRenderer.java:138)
E/GeckoAppShell( 1701): 	at org.mozilla.gecko.ScreenshotHandler$1.run(GeckoAppShell.java:2422)
E/GeckoAppShell( 1701): 	at android.os.Handler.handleCallback(Handler.java:587)
E/GeckoAppShell( 1701): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/GeckoAppShell( 1701): 	at android.os.Looper.loop(Looper.java:123)
E/GeckoAppShell( 1701): 	at org.mozilla.gecko.GeckoBackgroundThread.run(GeckoBackgroundThread.java:31)

Comment 1

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=13068826&tree=Mozilla-Inbound