Last Comment Bug 768428 - B2G RIL: REQUEST_GET_IMSI doesn't have response on Akami
: B2G RIL: REQUEST_GET_IMSI doesn't have response on Akami
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Linux
: -- normal (vote)
: mozilla16
Assigned To: Yoshi Huang[:allstars.chh]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-26 06:08 PDT by Yoshi Huang[:allstars.chh]
Modified: 2012-06-28 01:11 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch to Get IMSI (1.04 KB, patch)
2012-06-26 08:54 PDT, Yoshi Huang[:allstars.chh]
philipp: review+
Details | Diff | Splinter Review
Patch to Get IMSI. v2 (1.05 KB, patch)
2012-06-26 11:56 PDT, Yoshi Huang[:allstars.chh]
no flags Details | Diff | Splinter Review

Description Yoshi Huang[:allstars.chh] 2012-06-26 06:08:52 PDT
REQUEST_GET_IMSI doesn't get any response on Akami.
Comment 1 Yoshi Huang[:allstars.chh] 2012-06-26 07:59:54 PDT
adb logcat -b radio
E/RILD    (   99): **RIL Daemon Started**
E/RILD    (   99): **RILd param count=1**
E/RILD    (   99): RIL_Init argc = 5 client = 0
E/RILPROXY(   95): Could not connect to rild socket, retrying: Connection refused
E/RILPROXY(   95): Could not connect to rild socket, retrying: Connection refused
E/RILPROXY(   95): Could not connect to rild socket, retrying: Connection refused
E/RILPROXY(   95): Could not connect to rild socket, retrying: Connection refused
W/RILC    (   99): RIL_onUnsolicitedSendResponse called before RIL_register
E/RILD    (   99): isMultiSimEnabled: prop_val = 0 enabled = 0
E/RILC    (   99): RIL_register: RIL version 6
E/RILC    (   99): s_registerCalled = 1, s_started = 1, RIL_getMaxNumClients = 1
E/RILC    (   99): invalid command block for token 7 request GET_IMSI and client_id 0
Comment 2 Yoshi Huang[:allstars.chh] 2012-06-26 08:23:19 PDT
Found out that RIL_REQUEST_GET_IMSI has added an extra argument in ril v6
and Akami needs this argument (although galaxy s2 doesn't)
will take this bug and verify this on akami and galaxy s2
Comment 3 Yoshi Huang[:allstars.chh] 2012-06-26 08:54:33 PDT
Created attachment 636729 [details] [diff] [review]
Patch to Get IMSI
Comment 4 Philipp von Weitershausen [:philikon] 2012-06-26 11:45:09 PDT
Comment on attachment 636729 [details] [diff] [review]
Patch to Get IMSI

Review of attachment 636729 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +998,5 @@
>  
>    getIMSI: function getIMSI() {
> +    if (RILQUIRKS_V5_LEGACY) {
> +      Buf.simpleRequest(REQUEST_GET_IMSI);
> +    } else {

Nit: I have a small preference for bail out early here, so that at some point when we remove RILQUIRKS_V5_LEGACY support, we only have to remove an `if` block:

  if (RILQUIRKS_V5_LEGACY) {
    Buf.simpleRequest(REQUEST_GET_IMSI);
    return;
  }
  let token = Buf.newParcel(REQUEST_GET_IMSI);
  ...

r=me with that.
Comment 5 Yoshi Huang[:allstars.chh] 2012-06-26 11:56:04 PDT
Created attachment 636816 [details] [diff] [review]
Patch to Get IMSI. v2

Philikon's comments addressed!

Thanks for the quick review, philikon :)
Comment 6 Yoshi Huang[:allstars.chh] 2012-06-26 23:11:56 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/df7bd51e9a55
Comment 7 Ed Morley [:emorley] 2012-06-27 03:36:24 PDT
Landed directly onto m-c to speed things up:
https://hg.mozilla.org/mozilla-central/rev/a12ce6b09f13
Comment 8 Ed Morley [:emorley] 2012-06-28 01:11:40 PDT
https://hg.mozilla.org/mozilla-central/rev/df7bd51e9a55

Note You need to log in before you can comment on or make changes to this bug.