B2G RIL: REQUEST_GET_IMSI doesn't have response on Akami

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: allstars, Assigned: allstars)

Tracking

Trunk
mozilla16
ARM
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
REQUEST_GET_IMSI doesn't get any response on Akami.
(Assignee)

Comment 1

5 years ago
adb logcat -b radio
E/RILD    (   99): **RIL Daemon Started**
E/RILD    (   99): **RILd param count=1**
E/RILD    (   99): RIL_Init argc = 5 client = 0
E/RILPROXY(   95): Could not connect to rild socket, retrying: Connection refused
E/RILPROXY(   95): Could not connect to rild socket, retrying: Connection refused
E/RILPROXY(   95): Could not connect to rild socket, retrying: Connection refused
E/RILPROXY(   95): Could not connect to rild socket, retrying: Connection refused
W/RILC    (   99): RIL_onUnsolicitedSendResponse called before RIL_register
E/RILD    (   99): isMultiSimEnabled: prop_val = 0 enabled = 0
E/RILC    (   99): RIL_register: RIL version 6
E/RILC    (   99): s_registerCalled = 1, s_started = 1, RIL_getMaxNumClients = 1
E/RILC    (   99): invalid command block for token 7 request GET_IMSI and client_id 0
(Assignee)

Comment 2

5 years ago
Found out that RIL_REQUEST_GET_IMSI has added an extra argument in ril v6
and Akami needs this argument (although galaxy s2 doesn't)
will take this bug and verify this on akami and galaxy s2
Assignee: nobody → allstars.chh
(Assignee)

Comment 3

5 years ago
Created attachment 636729 [details] [diff] [review]
Patch to Get IMSI
Attachment #636729 - Flags: review?(philipp)
Comment on attachment 636729 [details] [diff] [review]
Patch to Get IMSI

Review of attachment 636729 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +998,5 @@
>  
>    getIMSI: function getIMSI() {
> +    if (RILQUIRKS_V5_LEGACY) {
> +      Buf.simpleRequest(REQUEST_GET_IMSI);
> +    } else {

Nit: I have a small preference for bail out early here, so that at some point when we remove RILQUIRKS_V5_LEGACY support, we only have to remove an `if` block:

  if (RILQUIRKS_V5_LEGACY) {
    Buf.simpleRequest(REQUEST_GET_IMSI);
    return;
  }
  let token = Buf.newParcel(REQUEST_GET_IMSI);
  ...

r=me with that.
Attachment #636729 - Flags: review?(philipp) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 636816 [details] [diff] [review]
Patch to Get IMSI. v2

Philikon's comments addressed!

Thanks for the quick review, philikon :)
Attachment #636729 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/df7bd51e9a55
Target Milestone: --- → mozilla16

Comment 7

5 years ago
Landed directly onto m-c to speed things up:
https://hg.mozilla.org/mozilla-central/rev/a12ce6b09f13
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/df7bd51e9a55
You need to log in before you can comment on or make changes to this bug.