768529 - SMS: Whitelist URI checking should use nsContentUtils::URIIsChromeOrInPref

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Marshall Culpepper [:marshall_law]]

There is a chunk of code in the SMS whitelist check that should be removed in favor of nsContentUtils::URLIsChromeOrInPref:

>  nsCAutoString uriPrePath;
>  uri->GetPrePath(uriPrePath);
>
>  const nsAdoptingString& whitelist =
>    Preferences::GetString("dom.sms.whitelist");
>
>  nsCharSeparatedTokenizer tokenizer(whitelist, ',',
>                                       nsCharSeparatedTokenizerTemplate<>::SEPARATOR_OPTIONAL);

>  while (tokenizer.hasMoreTokens()) {
>    const nsSubstring& whitelistItem = tokenizer.nextToken();
>
>    if (NS_ConvertUTF16toUTF8(whitelistItem).Equals(uriPrePath)) {
>      return true;
>    }
>  }
>
>  // The current page hasn't been whitelisted.
>  return false;

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Aren't we moving on to permission manager based API in bug 707659?