Closed Bug 768598 Opened 11 years ago Closed 11 years ago

add support for saving LR register

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: vlad, Assigned: vlad)

Details

Attachments

(1 file, 1 obsolete file)

Save ARM LR register in profiles
2.75 KB, patch
BenWa
: review+
Details | Diff | Splinter Review
Attached patch Save ARM LR register in profiles (obsolete) — — Splinter Review 
This is a hacky stopgap until we get full stack walking support.  We save the LR register with every PC sample, and then in the profiler UI we trust LR only from a set of whitelisted functions (mainly leaf functions from libc/bionic, e.g. various sycalls).  This gives us a bit of a better idea what's being called, even if we don't have the full stack.
Attachment #636830 - Flags: review?(bgirard)
Missing #ifdefs around saving ->lr
Attachment #636830 - Attachment is obsolete: true
Attachment #636830 - Flags: review?(bgirard)
Attachment #636837 - Flags: review?(bgirard)
Comment on attachment 636837 [details] [diff] [review]
Save ARM LR register in profiles

r+ with the ifdef fixed to only add the L labels if we're coming from platform-linux so we don't trigger this on say windows arm.
Attachment #636837 - Flags: review?(bgirard) → review+
On inbound as 2e9813915a1b
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/2e9813915a1b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.