Last Comment Bug 768598 - add support for saving LR register
: add support for saving LR register
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Gecko Profiler (show other bugs)
: unspecified
: ARM Android
: -- normal (vote)
: mozilla16
Assigned To: Vladimir Vukicevic [:vlad] [:vladv]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-26 12:30 PDT by Vladimir Vukicevic [:vlad] [:vladv]
Modified: 2012-07-04 14:03 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Save ARM LR register in profiles (2.70 KB, patch)
2012-06-26 12:30 PDT, Vladimir Vukicevic [:vlad] [:vladv]
no flags Details | Diff | Review
Save ARM LR register in profiles (2.75 KB, patch)
2012-06-26 12:42 PDT, Vladimir Vukicevic [:vlad] [:vladv]
bgirard: review+
Details | Diff | Review

Description Vladimir Vukicevic [:vlad] [:vladv] 2012-06-26 12:30:23 PDT
Created attachment 636830 [details] [diff] [review]
Save ARM LR register in profiles

This is a hacky stopgap until we get full stack walking support.  We save the LR register with every PC sample, and then in the profiler UI we trust LR only from a set of whitelisted functions (mainly leaf functions from libc/bionic, e.g. various sycalls).  This gives us a bit of a better idea what's being called, even if we don't have the full stack.
Comment 1 Vladimir Vukicevic [:vlad] [:vladv] 2012-06-26 12:42:14 PDT
Created attachment 636837 [details] [diff] [review]
Save ARM LR register in profiles

Missing #ifdefs around saving ->lr
Comment 2 Benoit Girard (:BenWa) 2012-06-26 13:56:07 PDT
Comment on attachment 636837 [details] [diff] [review]
Save ARM LR register in profiles

r+ with the ifdef fixed to only add the L labels if we're coming from platform-linux so we don't trigger this on say windows arm.
Comment 3 Vladimir Vukicevic [:vlad] [:vladv] 2012-07-04 08:26:09 PDT
On inbound as 2e9813915a1b
Comment 4 :Ehsan Akhgari (out sick) 2012-07-04 14:03:56 PDT
https://hg.mozilla.org/mozilla-central/rev/2e9813915a1b

Note You need to log in before you can comment on or make changes to this bug.