add support for saving LR register

RESOLVED FIXED in mozilla16

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vlad, Assigned: vlad)

Tracking

unspecified
mozilla16
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 636830 [details] [diff] [review]
Save ARM LR register in profiles

This is a hacky stopgap until we get full stack walking support.  We save the LR register with every PC sample, and then in the profiler UI we trust LR only from a set of whitelisted functions (mainly leaf functions from libc/bionic, e.g. various sycalls).  This gives us a bit of a better idea what's being called, even if we don't have the full stack.
Attachment #636830 - Flags: review?(bgirard)
(Assignee)

Comment 1

5 years ago
Created attachment 636837 [details] [diff] [review]
Save ARM LR register in profiles

Missing #ifdefs around saving ->lr
Attachment #636830 - Attachment is obsolete: true
Attachment #636830 - Flags: review?(bgirard)
Attachment #636837 - Flags: review?(bgirard)
Comment on attachment 636837 [details] [diff] [review]
Save ARM LR register in profiles

r+ with the ifdef fixed to only add the L labels if we're coming from platform-linux so we don't trigger this on say windows arm.
Attachment #636837 - Flags: review?(bgirard) → review+
(Assignee)

Comment 3

5 years ago
On inbound as 2e9813915a1b
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/2e9813915a1b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.