Add missing PropertyId rooting methods

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 636854 [details] [diff] [review]
v0

These are needed for the rooting analysis and for exact stack rooting.
Attachment #636854 - Flags: review?(jwalden+bmo)
Attachment #636854 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/57127eda3007

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/57127eda3007
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
gcc disagrees:

js/src/jsgc.cpp: In function ‘void js::MarkExactStackRoots(JSTracer*)’:
js/src/jsgc.cpp:883:100: error: cannot convert ‘jsid’ to ‘jsid*’ for argument ‘2’ to ‘void js::gc::MarkIdRoot(JSTracer*, jsid*, const char*)’
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 638422 [details] [diff] [review]
Followup to fix PropertyId exact root marking
Attachment #638422 - Flags: review?(jwalden+bmo)
(Assignee)

Comment 5

5 years ago
Comment on attachment 638422 [details] [diff] [review]
Followup to fix PropertyId exact root marking

Review of attachment 638422 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about the bustage.  I put the equivalent to this patch in my tree last night, but didn't have internet today to upload it.
Attachment #638422 - Flags: review?(jwalden+bmo) → review+
Whiteboard: [js:t]
http://hg.mozilla.org/integration/mozilla-inbound/rev/1e6e5607105d

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/1e6e5607105d
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.