Last Comment Bug 768626 - Add missing PropertyId rooting methods
: Add missing PropertyId rooting methods
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Terrence Cole [:terrence]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-26 13:31 PDT by Terrence Cole [:terrence]
Modified: 2012-07-26 05:09 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v0 (3.71 KB, patch)
2012-06-26 13:31 PDT, Terrence Cole [:terrence]
jwalden+bmo: review+
Details | Diff | Review
Followup to fix PropertyId exact root marking (2.29 KB, patch)
2012-07-02 11:21 PDT, Steve Fink [:sfink] [:s:]
terrence: review+
Details | Diff | Review

Description Terrence Cole [:terrence] 2012-06-26 13:31:59 PDT
Created attachment 636854 [details] [diff] [review]
v0

These are needed for the rooting analysis and for exact stack rooting.
Comment 1 Terrence Cole [:terrence] 2012-06-26 13:44:42 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/57127eda3007
Comment 2 Ed Morley [:emorley] 2012-06-27 03:35:31 PDT
https://hg.mozilla.org/mozilla-central/rev/57127eda3007
Comment 3 Steve Fink [:sfink] [:s:] 2012-07-02 11:20:12 PDT
gcc disagrees:

js/src/jsgc.cpp: In function ‘void js::MarkExactStackRoots(JSTracer*)’:
js/src/jsgc.cpp:883:100: error: cannot convert ‘jsid’ to ‘jsid*’ for argument ‘2’ to ‘void js::gc::MarkIdRoot(JSTracer*, jsid*, const char*)’
Comment 4 Steve Fink [:sfink] [:s:] 2012-07-02 11:21:38 PDT
Created attachment 638422 [details] [diff] [review]
Followup to fix PropertyId exact root marking
Comment 5 Terrence Cole [:terrence] 2012-07-02 23:44:21 PDT
Comment on attachment 638422 [details] [diff] [review]
Followup to fix PropertyId exact root marking

Review of attachment 638422 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about the bustage.  I put the equivalent to this patch in my tree last night, but didn't have internet today to upload it.
Comment 6 Steve Fink [:sfink] [:s:] 2012-07-25 16:32:42 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/1e6e5607105d
Comment 7 Ed Morley [:emorley] 2012-07-26 05:09:20 PDT
https://hg.mozilla.org/mozilla-central/rev/1e6e5607105d

Note You need to log in before you can comment on or make changes to this bug.