768636 - span.toggle that opens/closes the menu should be outside the nav-element

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Isac Lagerblad (:icaaq)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/16.0 Firefox/16.0
Build ID: 20120626030539

Steps to reproduce:

1. Press Cmd+N to open a new browser window, then type https://www.mozilla.org/en-US/ in the address bar and press Enter
2. resize the browser to < 760px
3. Inspect the element span.toggle element located in the #masthead > #nav-main


Actual results:

The span.toggle element is located inside of the nav#nav-main element


Expected results:

From the HTML5 Spec [1]. The nav element represents a section of a page that links to other pages or to parts within the page: a section with navigation links.

The toggle-button only toggles the nav-element and it's not a navigational link and should therefor be moved out from the nav-element. It would be most appropriate to have it before the nav-element.

[1] http://dev.w3.org/html5/spec/the-nav-element.html#the-nav-element

Comment 1

[ShanSM]

Hi,

I just registered and was able to get bedrock to successfully load locally on my system. I thought this would be a good first bug to tackle. Is it possible to get this assigned to me please?

Also I had a few quick questions about contributing:

1. When I make my changes do I create a new branch off of master for the bug fix?
2. If I do git pull and git fetch on the master branch will that update all other branches also?

Thanks!

Comment 2

[Ben (:bensternthal)]

Assigned to you.

To answer your questions, I think they are addressed here:

http://bedrock.readthedocs.org/en/latest/contribute.html

If you still have questions pop into #www or #webprod in IRC and one of us will gladly help you.

Comment 3

[ShanSM]

Has anybody had this issue where you run bedrock locally but then the styling does not compile and as a result is not applied to the page? I'm noticing sometimes it gets compiled and then sometimes it doesn't. I even tried with git checkout . to clean any local changes and I get the same result.

Comment 4

[Ben (:bensternthal)]

ShanSM I would suggest opening up a new bug for the specific issue you are describing. Please detail how you are running locally... using vagrant or virtualenv.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/4ea586fc275456a842c00939e65e8baa322f20e9
fix bug 768636 move span tag inside of block site_header_nav

https://github.com/mozilla/bedrock/commit/024c8c8e12fff2672ab1c8b127525213bd8eccf9
Merge pull request #1281 from shansm/headerfix-branch

fix bug 768636 move span.toggle outside of nav element