Device Storage - Add test that verifies the content written

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

Trunk
mozilla16
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

6.16 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → doug.turner
(Assignee)

Comment 1

5 years ago
Created attachment 636884 [details] [diff] [review]
patch v.1

changes to test cases only


* test_basic.html now verifies the content that was added to device storage.

* this also includes some prep for IPC in tests.  For example, devicestorage_setup now only sets prefs if we are in the main process.

* also minor clean up
Attachment #636884 - Flags: review?(bent.mozilla)
(Assignee)

Updated

5 years ago
Blocks: 761930
Attachment #636884 - Flags: review?(bent.mozilla) → review+
(Assignee)

Updated

5 years ago
Blocks: 773798
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3f14a850269
Sorry, but your push had to be backed out due to compilation errors on all platforms.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7db81ae082e7

/builds/slave/m-in-lnx/build/dom/ipc/PContent.ipdl:166: error: ctor for protocol `PDeviceStorageRequest', which is not managed by protocol `PContent'
Specification is not well typed.
(Assignee)

Comment 4

5 years ago
bad rebase - https://hg.mozilla.org/integration/mozilla-inbound/rev/75f82fd7b2b0
https://hg.mozilla.org/mozilla-central/rev/75f82fd7b2b0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.