Closed Bug 768684 Opened 8 years ago Closed 8 years ago

Fix sequence<any> return type in WebIDL

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: peterv, Assigned: peterv)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v1 (obsolete) — Splinter Review
The codegen check for type any before checking for sequence, we need to invert that.
Attachment #636908 - Flags: review?(bzbarsky)
Comment on attachment 636908 [details] [diff] [review]
v1

Hmm.  Does tag() on sequences forward on to the inner?  That seems bogus to me (and in fact there's an XXX comment by Kyle about it).  This also means that isAny() returns true for sequence<any>, which is broken.  And I guess isObject() and isDate() have similar problems.

I would prefer we just fix isAny() to work correctly and use it here.  For now we can just check |not self.isSequence()| in there in addition to the tag check (and similar for isDate() and isObject()), but we should really just fix the tag() on sequence behavior....
Attachment #636908 - Flags: review?(bzbarsky) → review-
Attached patch v2Splinter Review
Attachment #636908 - Attachment is obsolete: true
Attachment #655679 - Flags: review?(bzbarsky)
Comment on attachment 655679 [details] [diff] [review]
v2

r=me
Attachment #655679 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/05ce8d0d6e98
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.