The default bug view has changed. See this FAQ.

Split up BasicLayers.cpp into a few files

RESOLVED FIXED in mozilla16

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nrc, Assigned: nrc)

Tracking

15 Branch
mozilla16
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
It's just too big and it makes my head hurt
(Assignee)

Comment 1

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=4be379a4e391
(Assignee)

Comment 2

5 years ago
Created attachment 637000 [details] [diff] [review]
split up basiclayers.cpp
Attachment #637000 - Flags: review?(roc)
Comment on attachment 637000 [details] [diff] [review]
split up basiclayers.cpp

Review of attachment 637000 [details] [diff] [review]:
-----------------------------------------------------------------

I think if you use hg copy to copy BasicLayers.cpp to all the new files, then delete the code each file doesn't need, we can still have usable history for each file and a cleaner diff to review here.
(Assignee)

Comment 4

5 years ago
Created attachment 637704 [details] [diff] [review]
split up basiclayers.cpp
Attachment #637000 - Attachment is obsolete: true
Attachment #637000 - Flags: review?(roc)
Attachment #637704 - Flags: review?(roc)
Attachment #637704 - Flags: review?(roc) → review+
(Assignee)

Comment 5

5 years ago
try push: https://tbpl.mozilla.org/?tree=Try&rev=0aa7230a9f66
(Assignee)

Comment 6

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=3c5f8eb756bf
https://hg.mozilla.org/mozilla-central/rev/3c5f8eb756bf
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

Comment 8

5 years ago
Usable history: great.

Making diffstat think you removed 40000 lines of code: awesome.

hg log --stat -r 3c5f8eb756bf
You need to log in before you can comment on or make changes to this bug.