Last Comment Bug 768723 - Split up BasicLayers.cpp into a few files
: Split up BasicLayers.cpp into a few files
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: 15 Branch
: x86_64 Windows 7
: -- normal (vote)
: mozilla16
Assigned To: Nick Cameron [:nrc]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-26 17:37 PDT by Nick Cameron [:nrc]
Modified: 2012-07-17 18:44 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
split up basiclayers.cpp (247.93 KB, patch)
2012-06-26 22:27 PDT, Nick Cameron [:nrc]
no flags Details | Diff | Splinter Review
split up basiclayers.cpp (1.33 MB, patch)
2012-06-28 15:28 PDT, Nick Cameron [:nrc]
roc: review+
Details | Diff | Splinter Review

Description Nick Cameron [:nrc] 2012-06-26 17:37:05 PDT
It's just too big and it makes my head hurt
Comment 1 Nick Cameron [:nrc] 2012-06-26 22:27:02 PDT
https://tbpl.mozilla.org/?tree=Try&rev=4be379a4e391
Comment 2 Nick Cameron [:nrc] 2012-06-26 22:27:44 PDT
Created attachment 637000 [details] [diff] [review]
split up basiclayers.cpp
Comment 3 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2012-06-26 22:34:01 PDT
Comment on attachment 637000 [details] [diff] [review]
split up basiclayers.cpp

Review of attachment 637000 [details] [diff] [review]:
-----------------------------------------------------------------

I think if you use hg copy to copy BasicLayers.cpp to all the new files, then delete the code each file doesn't need, we can still have usable history for each file and a cleaner diff to review here.
Comment 4 Nick Cameron [:nrc] 2012-06-28 15:28:01 PDT
Created attachment 637704 [details] [diff] [review]
split up basiclayers.cpp
Comment 5 Nick Cameron [:nrc] 2012-06-28 23:00:36 PDT
try push: https://tbpl.mozilla.org/?tree=Try&rev=0aa7230a9f66
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-06-30 12:45:56 PDT
https://hg.mozilla.org/mozilla-central/rev/3c5f8eb756bf
Comment 8 Jesse Ruderman 2012-07-17 18:44:15 PDT
Usable history: great.

Making diffstat think you removed 40000 lines of code: awesome.

hg log --stat -r 3c5f8eb756bf

Note You need to log in before you can comment on or make changes to this bug.