768765 - "Assertion failure: selection->Collapsed() (Selection not collapsed after delete)" with multiple selections, odd history

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

Assertion failure: selection->Collapsed() (Selection not collapsed after delete), at editor/libeditor/base/nsEditor.cpp:4457

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

The assert is wrong: the selection might legitimately have multiple ranges that are all collapsed, in which case it won't be itself collapsed.  So let's instead just assert that the anchor/focus range is collapsed.  Try: https://tbpl.mozilla.org/?tree=Try&rev=99ea4154c5bf

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35db35b62cee

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/35db35b62cee