768846 - Resize issues in Responsive mode with Toolbox open

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/16.0 Firefox/16.0

1. Load any page in Firefox.
2. Open Responsive mode (select any preset with height lower than 600)
3. Open Debugger.
4. Attempt to resize the page to a higher height.

Actual result: Responsive mode window resizes to the lowest possible height.

Comment 1

[Paul Rouget [:paul]]

Indeed. It happens with the debugger, but not with the console.

Comment 2

[Paul Rouget [:paul]]

Attachment: screencast

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

So the important bit is to first resize the page in the responsive view to a height that is lower than the available content height, and then try to make it larger than the content height. If the height is larger than the available height initially, resizing works as expected.

If you open both the debugger and web console, then resizing works fine, even when the mouse pointer is over the console panel, until it reaches past the debugger splitter, into the debugger toolbar. My guess is that something in the toolbar styling causes this.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Panos Astithas [:past] from comment #3)
> If you open both the debugger and web console, then resizing works fine,
> even when the mouse pointer is over the console panel, until it reaches past
> the debugger splitter, into the debugger toolbar. My guess is that something
> in the toolbar styling causes this.

I removed all toolbar styling from debugger.xul, but the problem didn't go away.

Comment 5

[Paul Rouget [:paul]]

This is now happening with the toolbox (so with all the tools).

Comment 6

[Paul Rouget [:paul]]

Attachment: patch v1

ClientY is relative to the document firing the event. So because the toolbox (and the debugger previously) is in an iframe, we get a very small number when entering the box.

It works much better with ScreenX/Y.

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 690826 [details] [diff] [review]
patch v1

Review of attachment 690826 [details] [diff] [review]:
-----------------------------------------------------------------

Me likey.

Comment 8

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/f7ead5ca7000

Comment 9

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?rev=8a30e07815ff