Closed Bug 768846 Opened 8 years ago Closed 8 years ago

Resize issues in Responsive mode with Toolbox open

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: virgil.dicu, Assigned: paul)

References

Details

Attachments

(2 files)

Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/16.0 Firefox/16.0

1. Load any page in Firefox.
2. Open Responsive mode (select any preset with height lower than 600)
3. Open Debugger.
4. Attempt to resize the page to a higher height.

Actual result: Responsive mode window resizes to the lowest possible height.
Indeed. It happens with the debugger, but not with the console.
Attached video screencast
So the important bit is to first resize the page in the responsive view to a height that is lower than the available content height, and then try to make it larger than the content height. If the height is larger than the available height initially, resizing works as expected.

If you open both the debugger and web console, then resizing works fine, even when the mouse pointer is over the console panel, until it reaches past the debugger splitter, into the debugger toolbar. My guess is that something in the toolbar styling causes this.
Priority: -- → P3
(In reply to Panos Astithas [:past] from comment #3)
> If you open both the debugger and web console, then resizing works fine,
> even when the mouse pointer is over the console panel, until it reaches past
> the debugger splitter, into the debugger toolbar. My guess is that something
> in the toolbar styling causes this.

I removed all toolbar styling from debugger.xul, but the problem didn't go away.
Summary: Resize issues in Responsive mode with Debugger open → Resize issues in Responsive mode with Toolbox open
This is now happening with the toolbox (so with all the tools).
Blocks: 816946
Attached patch patch v1Splinter Review
ClientY is relative to the document firing the event. So because the toolbox (and the debugger previously) is in an iframe, we get a very small number when entering the box.

It works much better with ScreenX/Y.
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #690826 - Flags: review?(vporof)
Comment on attachment 690826 [details] [diff] [review]
patch v1

Review of attachment 690826 [details] [diff] [review]:
-----------------------------------------------------------------

Me likey.
Attachment #690826 - Flags: review?(vporof) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/f7ead5ca7000
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://tbpl.mozilla.org/?rev=8a30e07815ff
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.