Closed Bug 76894 Opened 25 years ago Closed 25 years ago

crash in nsObeliskLayout, null pointer check needed

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: hewitt, Assigned: hewitt)

References

Details

Attachments

(1 file)

I experienced a crash in nsObeliskLayout::ChildBecameDirty while inserting a newly created treeitem (with a pretty deep set of nodes beneath it). Got a crash on line 264 in nsObeliskLayout::ChildBecameDirty saying that parent is null. Simply doing a null pointer check and returning prevented the crash and solved the problem. This patch is just two lines. I don't know if there are any negative implications caused by bailing out of ChildBecameDirty at that point, so reviewers please consider the patch carefully :)
Attached patch patch to fix — — Splinter Review
Blocks: 43189
[s]r=hyatt
-r=evaughan
Joe, Can you check in your patch?
Assignee: evaughan → hewitt
fixed
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: