Closed Bug 769077 Opened 9 years ago Closed 9 years ago

Uninitialized render buffers do not report memory usage correctly

Categories

(Core :: Canvas: WebGL, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla16

People

(Reporter: jon, Assigned: jon)

Details

Attachments

(2 files)

Attached file test case
I found this while running the WebGL Conformance Tests in a debug build of trunk. If you visit the attached webpage and then visit about:memory, Firefox will always NS_ABORT() when getting the memory usage of unintialized render buffers. This is because it doesn't handle the case where mInternalFormatForGL is null.
Attached patch Patch v1Splinter Review
Here's a patch that handles the null case for render buffers and textures.

Try server run: https://tbpl.mozilla.org/?tree=Try&rev=09132969a207
Attachment #637303 - Flags: review?(bjacob)
Attachment #637303 - Flags: review?(bjacob) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/74e381773948
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Opening the test case and about:memory in today's Nightly does not cause a crash now.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.