Uninitialized render buffers do not report memory usage correctly

VERIFIED FIXED in mozilla16

Status

()

Core
Canvas: WebGL
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Jon Buckley, Assigned: Jon Buckley)

Tracking

unspecified
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 637286 [details]
test case

I found this while running the WebGL Conformance Tests in a debug build of trunk. If you visit the attached webpage and then visit about:memory, Firefox will always NS_ABORT() when getting the memory usage of unintialized render buffers. This is because it doesn't handle the case where mInternalFormatForGL is null.
(Assignee)

Comment 1

5 years ago
Created attachment 637303 [details] [diff] [review]
Patch v1

Here's a patch that handles the null case for render buffers and textures.

Try server run: https://tbpl.mozilla.org/?tree=Try&rev=09132969a207
Attachment #637303 - Flags: review?(bjacob)
Attachment #637303 - Flags: review?(bjacob) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/74e381773948
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/74e381773948
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
(Assignee)

Comment 4

5 years ago
Opening the test case and about:memory in today's Nightly does not cause a crash now.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.