769095 - Enforce maximum icon size for nsIAlertsService's notification

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Upon a successful webapp installation, we want to display a notification that an app has been installed. On the notification we display the app icon given to us, which can have any size, thus leading to an amusing result: http://i.imgur.com/kNjdd.png

Dão, how should this be handled? can I add a max-width/height 32x32 (or 48x48) on #alertImage in alert.css?  .alertImageBox has a min-width/height but I don't understand why

Comment 1

[Jason Smith [:jsmith]]

Flagging for tracking-firefox16 and k9o - this bug's implementation blocks the implementation of a k9o blocker for providing feedback on post-install, which therefore makes this a blocker.

Comment 2

[Alex Keybl [:akeybl]]

This doesn't appear to be a blocker for this feature in FF16 (separate from k9o), so no need to track. We'd definitely consider taking an uplift if/when ready, however.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Set max-width/height to 48px

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Attachment: Screenshot with patch applied

Comment 5

[Dan Walkowski]

hmm, perhaps it should have space around it, instead of being jammed against the top and bottom borders?

Comment 6

[Jason Smith [:jsmith]]

(In reply to Dan Walkowski from comment #5)
> hmm, perhaps it should have space around it, instead of being jammed against
> the top and bottom borders?

Makes sense to me. Probably a little bit of padding could help improve the look and feel a bit.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Let's leave that for a follow-up though as we'll probably do more fine tuning on the notification appearance. And use this bug only for the necessary part to land the feedback notification, i.e. enforcing a maximum size for the icon.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/977ee9208065

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20a09c21d3d5
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bfce37d7fa4

Comment 10

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/827cfcf5a41b