Enforce maximum icon size for nsIAlertsService's notification

VERIFIED FIXED in mozilla16

Status

()

defect
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

unspecified
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-kilimanjaro:?, firefox16-)

Details

(Whiteboard: [Desktop WebRT], [qa!])

Attachments

(2 attachments)

Upon a successful webapp installation, we want to display a notification that an app has been installed. On the notification we display the app icon given to us, which can have any size, thus leading to an amusing result: http://i.imgur.com/kNjdd.png

Dão, how should this be handled? can I add a max-width/height 32x32 (or 48x48) on #alertImage in alert.css?  .alertImageBox has a min-width/height but I don't understand why
Whiteboard: [Desktop WebRT]
Flagging for tracking-firefox16 and k9o - this bug's implementation blocks the implementation of a k9o blocker for providing feedback on post-install, which therefore makes this a blocker.
blocking-kilimanjaro: --- → ?
This doesn't appear to be a blocker for this feature in FF16 (separate from k9o), so no need to track. We'd definitely consider taking an uplift if/when ready, however.
Posted patch PatchSplinter Review
Set max-width/height to 48px
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Attachment #639830 - Flags: review?(dao)

Comment 5

7 years ago
hmm, perhaps it should have space around it, instead of being jammed against the top and bottom borders?
(In reply to Dan Walkowski from comment #5)
> hmm, perhaps it should have space around it, instead of being jammed against
> the top and bottom borders?

Makes sense to me. Probably a little bit of padding could help improve the look and feel a bit.
Let's leave that for a follow-up though as we'll probably do more fine tuning on the notification appearance. And use this bug only for the necessary part to land the feedback notification, i.e. enforcing a maximum size for the icon.
Component: XUL → Themes
Product: Core → Toolkit
Attachment #639830 - Flags: review?(dao) → review+
OS: Windows 7 → All
Whiteboard: [Desktop WebRT] → [Desktop WebRT], [qa+]
QA Contact: jsmith
http://hg.mozilla.org/mozilla-central/rev/827cfcf5a41b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Whiteboard: [Desktop WebRT], [qa+] → [Desktop WebRT], [qa!]
You need to log in before you can comment on or make changes to this bug.