Closed
Bug 769119
Opened 13 years ago
Closed 13 years ago
new Blob([], null/undefined); shouldn't throw
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: emk, Assigned: emk)
References
()
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
|
4.54 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
The Web IDL spec has been updated so that null or empty is treated as an empty dictionary.
| Assignee | ||
Updated•13 years ago
|
| Assignee | ||
Comment 1•13 years ago
|
||
> null or empty is treated
Correction: null or undefined is treated
Comment 2•13 years ago
|
||
We just need to switch Blob to WebIDL bindings. Then it would automatically pick up fixes like this...
Comment 3•13 years ago
|
||
But I guess in the meantime we can update the old dictionary code to work with undefined and null?
| Assignee | ||
Comment 4•13 years ago
|
||
Yeah, I believe this patch will suffice for a temporary solution until moving to New bindings.
Assignee: nobody → VYV03354
Attachment #637601 -
Flags: review?(jonas)
Comment 5•13 years ago
|
||
Could you add some tests for event ctors too.
Put them to content/events/test/test_eventctors.html
| Assignee | ||
Comment 6•13 years ago
|
||
Added tests for event ctors.
Attachment #637601 -
Attachment is obsolete: true
Attachment #637601 -
Flags: review?(jonas)
Attachment #637644 -
Flags: review?(jonas)
Attachment #637644 -
Flags: review?(jonas) → review+
| Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 7•13 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite+
Flags: in-moztrap-
Flags: in-litmus-
Keywords: checkin-needed → dev-doc-needed
Target Milestone: --- → mozilla16
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
Doc updated:
https://developer.mozilla.org/en-US/docs/Web/API/Blob.Blob#Browser_compatibility
and
https://developer.mozilla.org/en-US/Firefox/Releases/16#API.2FDOM
Keywords: dev-doc-needed → dev-doc-complete
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•