The default bug view has changed. See this FAQ.

new Blob([], null/undefined); shouldn't throw

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

({dev-doc-complete})

Trunk
mozilla16
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +
in-litmus -
in-moztrap -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
The Web IDL spec has been updated so that null or empty is treated as an empty dictionary.
(Assignee)

Updated

5 years ago
(Assignee)

Comment 1

5 years ago
> null or empty is treated
Correction: null or undefined is treated
We just need to switch Blob to WebIDL bindings.  Then it would automatically pick up fixes like this...
But I guess in the meantime we can update the old dictionary code to work with undefined and null?
(Assignee)

Comment 4

5 years ago
Created attachment 637601 [details] [diff] [review]
Bug 769119 - Treat null or undefined as an empty dictionary

Yeah, I believe this patch will suffice for a temporary solution until moving to New bindings.
Assignee: nobody → VYV03354
Attachment #637601 - Flags: review?(jonas)

Comment 5

5 years ago
Could you add some tests for event ctors too.
Put them to content/events/test/test_eventctors.html
(Assignee)

Comment 6

5 years ago
Created attachment 637644 [details] [diff] [review]
Bug 769119 - Treat null or undefined as an empty dictionary

Added tests for event ctors.
Attachment #637601 - Attachment is obsolete: true
Attachment #637601 - Flags: review?(jonas)
Attachment #637644 - Flags: review?(jonas)
Attachment #637644 - Flags: review?(jonas) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/82de1c252339
Status: NEW → ASSIGNED
Flags: in-testsuite+
Flags: in-moztrap-
Flags: in-litmus-
Keywords: checkin-needed → dev-doc-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/82de1c252339
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Doc updated:
https://developer.mozilla.org/en-US/docs/Web/API/Blob.Blob#Browser_compatibility
and
https://developer.mozilla.org/en-US/Firefox/Releases/16#API.2FDOM
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.