Closed
Bug 769142
Opened 13 years ago
Closed 12 years ago
SpiderMonkey builds need to reboot
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: catlee)
Details
(Whiteboard: [spidermonkey])
Attachments
(2 files)
|
702 bytes,
patch
|
catlee
:
feedback-
|
Details | Diff | Splinter Review |
|
1.08 KB,
patch
|
jhopkins
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
With win32-on-win64 down as far as Aurora already, Windows SpiderMonkey builds are a lot of the use of the Win32 slaves, so if one hangs like https://tbpl.mozilla.org/php/getParsedLog.php?id=13047845&tree=Ionmonkey did, then it just sits there - in this case, we were clobbering, so the clobberer failed from file-in-use until bug 769139 gave it what for, but I suspect that if we weren't clobbering, things would have gone rather poorly anyway.
| Reporter | ||
Updated•13 years ago
|
Whiteboard: [spidermonkey]
Comment 1•13 years ago
|
||
Do you think this would work?
| Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 637522 [details] [diff] [review]
[wip] reboot at the end
Review of attachment 637522 [details] [diff] [review]:
-----------------------------------------------------------------
I think it's better to use ScriptFactory's reboot_command, otherwise every spidermonkey job will go red because of the lost slave connection.
Attachment #637522 -
Flags: feedback?(catlee) → feedback-
Updated•13 years ago
|
Priority: -- → P3
Comment 4•13 years ago
|
||
cc'ing you Steve, because I know how much you love these scripts!
| Reporter | ||
Updated•13 years ago
|
Status: ASSIGNED → NEW
Priority: P3 → --
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
| Assignee | ||
Comment 5•12 years ago
|
||
Attachment #799588 -
Flags: review?(jhopkins)
| Assignee | ||
Updated•12 years ago
|
Assignee: nobody → catlee
Comment 6•12 years ago
|
||
Comment on attachment 799588 [details] [diff] [review]
use reboot command from tools
Would be nice to factor out the reboot_command at some point to avoid duplication of this code, but looks good otherwise.
Attachment #799588 -
Flags: review?(jhopkins) → review+
| Assignee | ||
Updated•12 years ago
|
Attachment #799588 -
Flags: checked-in+
Comment 7•12 years ago
|
||
In production
| Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•