Last Comment Bug 769238 - Rename aEffectsFrame to just aFrame in nsSVGIntegrationUtils
: Rename aEffectsFrame to just aFrame in nsSVGIntegrationUtils
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Jonathan Watt [:jwatt] (back in October - email directly if necessary)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-28 06:24 PDT by Jonathan Watt [:jwatt] (back in October - email directly if necessary)
Modified: 2012-06-29 00:47 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (6.85 KB, patch)
2012-06-28 06:25 PDT, Jonathan Watt [:jwatt] (back in October - email directly if necessary)
dholbert: review+
Details | Diff | Splinter Review

Description Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-06-28 06:24:12 PDT
The name aEffectsFrame in nsSVGIntegrationUtils sounds like it's the frame providing the effects, rather than the frame to which effects are being applied. We could call it something more meaningful, but frankly the name aFrame seems fine in its context.
Comment 1 Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-06-28 06:25:18 PDT
Created attachment 637493 [details] [diff] [review]
patch
Comment 2 Daniel Holbert [:dholbert] 2012-06-28 09:24:01 PDT
Comment on attachment 637493 [details] [diff] [review]
patch

Stealing review.
Comment 3 Jonathan Watt [:jwatt] (back in October - email directly if necessary) 2012-06-28 12:54:15 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/10ae67e2c60a
Comment 4 Ed Morley [:emorley] 2012-06-29 00:47:13 PDT
https://hg.mozilla.org/mozilla-central/rev/10ae67e2c60a

Note You need to log in before you can comment on or make changes to this bug.