Last Comment Bug 769238 - Rename aEffectsFrame to just aFrame in nsSVGIntegrationUtils
: Rename aEffectsFrame to just aFrame in nsSVGIntegrationUtils
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Jonathan Watt [:jwatt]
: Jet Villegas (:jet)
Depends on:
  Show dependency treegraph
Reported: 2012-06-28 06:24 PDT by Jonathan Watt [:jwatt]
Modified: 2012-06-29 00:47 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (6.85 KB, patch)
2012-06-28 06:25 PDT, Jonathan Watt [:jwatt]
dholbert: review+
Details | Diff | Splinter Review

Description Jonathan Watt [:jwatt] 2012-06-28 06:24:12 PDT
The name aEffectsFrame in nsSVGIntegrationUtils sounds like it's the frame providing the effects, rather than the frame to which effects are being applied. We could call it something more meaningful, but frankly the name aFrame seems fine in its context.
Comment 1 Jonathan Watt [:jwatt] 2012-06-28 06:25:18 PDT
Created attachment 637493 [details] [diff] [review]
Comment 2 Daniel Holbert [:dholbert] 2012-06-28 09:24:01 PDT
Comment on attachment 637493 [details] [diff] [review]

Stealing review.
Comment 4 Ed Morley [:emorley] 2012-06-29 00:47:13 PDT

Note You need to log in before you can comment on or make changes to this bug.