769291 - Offload evicting offline caches to Cache IO thread.

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Thinker Li [:sinker]]

OfflineCacheDevice remove entry data from database for evicting at main thread.  Remove these data tasks to cache IO thread can improve the performance.

Comment 1

[Thinker Li [:sinker]]

Attachment: WIP

Comment 2

[Thinker Li [:sinker]]

Attachment: Move nsOfflineCacheDevice::Discard() to cache IO thread

Comment 3

[Honza Bambas (:mayhemer)]

Thinker, can you confirm that access to sqlite is thread-safe?

Comment 4

[Andreas Gal :gal]

We already use SQLite from two threads here. This patch reduces that which is why it's faster (we lock the main thread without this patch).

Comment 5

[Honza Bambas (:mayhemer)]

Doing something doesn't mean it is safe.  Could anyone here confirm that accessing the connection is really thread safe?  From my experience it is not, but things might change since that time.

Comment 6

[Andreas Gal :gal]

The connection is thread safe. We use it currently from multiple threads. With this patch we only use it from one thread.

Comment 7

[Honza Bambas (:mayhemer)]

(In reply to Andreas Gal :gal from comment #6)
> The connection is thread safe. We use it currently from multiple threads.
> With this patch we only use it from one thread.

Thanks.

Comment 8

[Thinker Li [:sinker]]

Attachment: Move nsOfflineCacheDevice::Discard() to cache IO thread, v2

Comment 9

[Honza Bambas (:mayhemer)]

Comment on attachment 638617 [details] [diff] [review]
Move nsOfflineCacheDevice::Discard() to cache IO thread, v2

Review of attachment 638617 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab.  Let's get this in.  This is a good patch.

Comment 10

[Thinker Li [:sinker]]

Attachment: Move nsOfflineCacheDevice::Discard() to cache IO thread, v3

r=honzab

Comment 11

[Andreas Gal :gal]

Thinker, lets land this.

Comment 12

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f9bf790012b

Comment 13

[Thinker Li [:sinker]]

try https://tbpl.mozilla.org/?tree=Try&rev=e6589935be49

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5f9bf790012b