769294 - Crash when dumping layers in the console

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

Attachment: Trivial fix

The Dump method in LayerManager has a small bug: if the argument aFile is nil it is supposed to use terminal output by default. It is handled by the call to FILEOrDefault at the beginning of the method. However one of the fprintf calls that follow use the 'aFile' variable instead of 'file', resulting in a segfault when aFile is null, rather than writing in stdout.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a52d79ad75da

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a52d79ad75da