Crash when dumping layers in the console

RESOLVED FIXED in mozilla16

Status

()

Core
Graphics: Layers
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nical, Assigned: nical)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

962 bytes, patch
Joe Drew (not getting mail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 637523 [details] [diff] [review]
Trivial fix

The Dump method in LayerManager has a small bug: if the argument aFile is nil it is supposed to use terminal output by default. It is handled by the call to FILEOrDefault at the beginning of the method. However one of the fprintf calls that follow use the 'aFile' variable instead of 'file', resulting in a segfault when aFile is null, rather than writing in stdout.
(Assignee)

Updated

5 years ago
Attachment #637523 - Flags: review?(joe)
Attachment #637523 - Flags: review?(joe) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Assignee: nobody → nsilva
https://hg.mozilla.org/integration/mozilla-inbound/rev/a52d79ad75da
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/a52d79ad75da
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.