Last Comment Bug 769294 - Crash when dumping layers in the console
: Crash when dumping layers in the console
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: unspecified
: All All
: -- trivial (vote)
: mozilla16
Assigned To: Nicolas Silva [:nical]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-28 08:33 PDT by Nicolas Silva [:nical]
Modified: 2012-06-30 12:40 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Trivial fix (962 bytes, patch)
2012-06-28 08:33 PDT, Nicolas Silva [:nical]
joe: review+
Details | Diff | Splinter Review

Description Nicolas Silva [:nical] 2012-06-28 08:33:46 PDT
Created attachment 637523 [details] [diff] [review]
Trivial fix

The Dump method in LayerManager has a small bug: if the argument aFile is nil it is supposed to use terminal output by default. It is handled by the call to FILEOrDefault at the beginning of the method. However one of the fprintf calls that follow use the 'aFile' variable instead of 'file', resulting in a segfault when aFile is null, rather than writing in stdout.
Comment 1 Ryan VanderMeulen [:RyanVM] 2012-06-30 09:05:09 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/a52d79ad75da
Comment 2 Ryan VanderMeulen [:RyanVM] 2012-06-30 12:40:30 PDT
https://hg.mozilla.org/mozilla-central/rev/a52d79ad75da

Note You need to log in before you can comment on or make changes to this bug.