Note: There are a few cases of duplicates in user autocompletion which are being worked on.

B2G SMS: Messages returned from database should be sorted by time stamp.

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: steveck, Assigned: vicamo)

Tracking

unspecified
mozilla16
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Reporter)

Comment 1

5 years ago
This issue is also raised in github issue: https://github.com/mozilla-b2g/gaia/issues/2053#preview_bucket_971
(Reporter)

Comment 2

5 years ago
Created attachment 637586 [details]
Screenshot about the incorrect message thread sequence
(Assignee)

Comment 3

5 years ago
Created attachment 637592 [details] [diff] [review]
order database query results by timestamp

Inside SmsDatabaseService.keyIntersection(), the order of final results is the order of last keys array filtered. This patch always filters keys[FILTER_TIMESTAMP], so it should be always ordered by timestamp.
(In reply to Vicamo Yang [:vicamo] from comment #3)
> Inside SmsDatabaseService.keyIntersection(), the order of final results is
> the order of last keys array filtered. This patch always filters
> keys[FILTER_TIMESTAMP], so it should be always ordered by timestamp.

Good hack. Can you add a comment explaining this side-effect? r=me with that.
(Assignee)

Comment 5

5 years ago
Created attachment 638965 [details] [diff] [review]
order database query results by timestamp : V2

Address comment #4 from Philipp. Thank you.
Attachment #637592 - Attachment is obsolete: true
Attachment #638965 - Flags: review?(philipp)
(Assignee)

Comment 6

5 years ago
Gaia fix is ready here(https://github.com/vicamo/gaia/tree/bugzilla/769347/master). I'll send a pull request once this is landed.
Attachment #638965 - Flags: review?(philipp) → review+
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/d3cfb134c625
Assignee: nobody → vyang
Target Milestone: --- → mozilla16

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d3cfb134c625
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.