769347 - B2G SMS: Messages returned from database should be sorted by time stamp.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Steve Chung [:steveck]]

This issue is also raised in github issue: https://github.com/mozilla-b2g/gaia/issues/2053#preview_bucket_971

Comment 2

[Steve Chung [:steveck]]

Attachment: Screenshot about the incorrect message thread sequence

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: order database query results by timestamp

Inside SmsDatabaseService.keyIntersection(), the order of final results is the order of last keys array filtered. This patch always filters keys[FILTER_TIMESTAMP], so it should be always ordered by timestamp.

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to Vicamo Yang [:vicamo] from comment #3)
> Inside SmsDatabaseService.keyIntersection(), the order of final results is
> the order of last keys array filtered. This patch always filters
> keys[FILTER_TIMESTAMP], so it should be always ordered by timestamp.

Good hack. Can you add a comment explaining this side-effect? r=me with that.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Attachment: order database query results by timestamp : V2

Address comment #4 from Philipp. Thank you.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Gaia fix is ready here(https://github.com/vicamo/gaia/tree/bugzilla/769347/master). I'll send a pull request once this is landed.

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d3cfb134c625

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d3cfb134c625